Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

Worse essential page on dark mode #1385

Closed
deep5050 opened this issue Apr 22, 2020 · 4 comments · Fixed by #1390
Closed

Worse essential page on dark mode #1385

deep5050 opened this issue Apr 22, 2020 · 4 comments · Fixed by #1390
Labels
Status: Review Needed

Comments

@deep5050
Copy link

Essential page contents are barely visible on dark mode.
Screenshot_2020-04-22-07-29-07-281_com android chrome
@gyanendrapatro
Copy link
Contributor

I can fix it assign it to me

@SensehacK
Copy link
Contributor

I'm also working on it 👍

SensehacK added a commit to SensehacK/covid19india-react that referenced this issue Apr 22, 2020
@SensehacK
(style)DarkMode: Fixed covid19india#1385 Essentials Page.
5a0eaa7
@SensehacK SensehacK mentioned this issue Apr 22, 2020
Merged
6 tasks
@deep5050
Copy link
Author

Still have problems .
@SensehacK You didn't fix the position of feedback and add button for mobile devices.
If possible change the colour of these two buttons too . Blue over black is not eye catching.

Screenshot_2020-04-22-22-39-20-644_com android chrome

@SensehacK
Copy link
Contributor

@deep5050 We can have a color palette decided for dark mode in a new feature request!

I'll create the request.

It would add more consistency with the overall website.

@SensehacK SensehacK mentioned this issue Apr 22, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Status: Review Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Style: Dark mode for Essentials SensehacK/covid19india-react
3 participants
@SensehacK @gyanendrapatro @deep5050