feat(commerce): clean up now replaced controllers

[Spuffynism]

See commerce.index.ts to understand the scope of the changes. We remove top-level pagination, sort and facet generator controllers, in favor of those accessible through sub-controllers.

This PR is part of a series of cascading PRs: #3842

CAPI-719

[github-actions]

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File	Old (kb)	New (kb)	Change (%)
case-assist	202.6	202.6	0
commerce	267.8	266.3	-0.5
search	364.9	364.9	0
insight	345.5	345.5	0
product-listing	257.9	257.9	0
product-recommendation	171.6	171.6	0
recommendation	215.5	215.5	0
ssr	357.8	357.8	0

SSR Progress

Use case	SSR (#)	CSR (#)	Progress (%)
search	39	44	89
recommendation	0	4	0
product-recommendation	0	10	0
product-listing	0	13	0
case-assist	0	6	0
insight	0	27	0

Detailed logs

search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support

[olamothe]

Code delete is the best kind of PR to review

[Spuffynism]

@olamothe @louis-bompart @fbeaudoincoveo Some of the changes affect Atomic, and I'm not sure how to resolve them.

The atomic commerce pager for example uses the top-level pagination builders which are removed in this PR:

ui-kit/packages/atomic/src/components/commerce/atomic-commerce-pager/atomic-commerce-pager.tsx

Lines 92 to 94 in d1ee1c3

	this.pager = buildProductListingPagination(this.bindings.engine);
	} else if (this.bindings.interfaceElement.type === 'search') {
	this.pager = buildSearchPagination(this.bindings.engine);

I'm thinking we should expose the listing/search controller on the commerce bindings directly. Would that be right?

[fbeaudoincoveo]

@olamothe @louis-bompart @fbeaudoincoveo Some of the changes affect Atomic, and I'm not sure how to resolve them.

The atomic commerce pager for example uses the top-level pagination builders which are removed in this PR:

ui-kit/packages/atomic/src/components/commerce/atomic-commerce-pager/atomic-commerce-pager.tsx

Lines 92 to 94 in d1ee1c3

	this.pager = buildProductListingPagination(this.bindings.engine);
	} else if (this.bindings.interfaceElement.type === 'search') {
	this.pager = buildSearchPagination(this.bindings.engine);

I'm thinking we should expose the listing/search controller on the commerce bindings directly. Would that be right?

Yes that could work and IMO it would make sense since you'd build the pagination, sort, and facets from those "parent" controllers...

E.g., you'd have:

public initialize() {
  if (this.bindings.interfaceElement.type === 'product-listing') {
    this.pager = this.bindings.productListing.pagination();
  } else if (this.bindings.interfaceElement.type === 'search') {
    this.pager = this.bindings.search.pagination();
  }
}

@olamothe what's your take on this?

[olamothe]

@olamothe @louis-bompart @fbeaudoincoveo Some of the changes affect Atomic, and I'm not sure how to resolve them.
The atomic commerce pager for example uses the top-level pagination builders which are removed in this PR:

ui-kit/packages/atomic/src/components/commerce/atomic-commerce-pager/atomic-commerce-pager.tsx

Lines 92 to 94 in d1ee1c3

	this.pager = buildProductListingPagination(this.bindings.engine);
	} else if (this.bindings.interfaceElement.type === 'search') {
	this.pager = buildSearchPagination(this.bindings.engine);

I'm thinking we should expose the listing/search controller on the commerce bindings directly. Would that be right?

Yes that could work and IMO it would make sense since you'd build the pagination, sort, and facets from those "parent" controllers...

E.g., you'd have:

public initialize() {
  if (this.bindings.interfaceElement.type === 'product-listing') {
    this.pager = this.bindings.productListing.pagination();
  } else if (this.bindings.interfaceElement.type === 'search') {
    this.pager = this.bindings.search.pagination();
  }
}

@olamothe what's your take on this?

Let's do like this: https://github.com/coveo/ui-kit/pull/3895/files#diff-2fa6435e1e9a232914e7a52b08fc3d645170336854aba1f193646e220f23cdafR53-R60

[Spuffynism]

@olamothe @fbeaudoincoveo applied that suggestion in d9932b7