feat(commerce): expose facet generator as sub-controller #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support |
pvanool
approved these changes
Apr 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
To understand changes this enables, see: - #3854 where the pagination sub-controller is put to use - #3855 where we expose the facet sub-controllers - #3857 where we remove now replaced top-level controllers - #3859 where we expose the breadcrumb manager sub-controller To understand how we came to this solution, see: - #3825 where we tried slicing the pagination as a `Record` - #3800 where we added pagination and sort as sub-controllers ~And see feat-capi-719-sliced-pagination-states...feat-capi-719-sliced-structured-pagination-states for the diff between this approach and the above PR~ [CAPI-719] [CAPI-719]: https://coveord.atlassian.net/browse/CAPI-719?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
…acet-sub-controllers
fbeaudoincoveo
approved these changes
May 2, 2024
fpbrault
pushed a commit
that referenced
this pull request
May 2, 2024
Next step is removing the exports from `commerce.index.ts`, which I'll do in a follow-up PR! This PR is part of a series of cascading PRs: #3842 [CAPI-719] [CAPI-719]: https://coveord.atlassian.net/browse/CAPI-719?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step is removing the exports from
commerce.index.ts, which I'll do in a follow-up PR!This PR is part of a series of cascading PRs: #3842
CAPI-719