Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(organization): leverage organization property for servingExperimentsAllowed #841

Merged

Conversation

lprovost-coveo
Copy link
Contributor

@lprovost-coveo lprovost-coveo commented Jul 29, 2024

The organization has a new property (non-optional) called configuration which contains the boolean property servingExperiementsAllowed

The goal is to start leveraging the new property from the org and the new endpoint that was created to update that property.

  • Added the property to the organization definition
  • (breaking change) Removed the old entrypoint for getExperimentalStatus
  • Switched over the existing update call to leverage the new endpoint
  • Change the default from false to true since we don't promote false.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@lprovost-coveo lprovost-coveo force-pushed the feature/MLX-1321-update-serving-experiment-endpoint branch 3 times, most recently from 5a9b278 to 217c62d Compare July 29, 2024 15:39
…lowed

BREAKING CHANGE: Removal of getExperimentalStatus
@lprovost-coveo lprovost-coveo force-pushed the feature/MLX-1321-update-serving-experiment-endpoint branch from 217c62d to 1fc6b52 Compare July 29, 2024 15:41
@lprovost-coveo lprovost-coveo marked this pull request as ready for review July 29, 2024 15:46
@lprovost-coveo lprovost-coveo requested review from a team as code owners July 29, 2024 15:46
Copy link
Contributor

@mcnoreau12 mcnoreau12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@JTangCoveo JTangCoveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lprovost-coveo lprovost-coveo added this pull request to the merge queue Aug 1, 2024
Merged via the queue into master with commit bfc43cf Aug 1, 2024
5 checks passed
@lprovost-coveo lprovost-coveo deleted the feature/MLX-1321-update-serving-experiment-endpoint branch August 1, 2024 18:37
Copy link

github-actions bot commented Aug 1, 2024

🎉 This issue has been resolved in version 55.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants