refactor(organization): leverage organization property for servingExp…

…erimentsAllowed (#841) refactor(organization): leverage organization for servingExperimentAllowed BREAKING CHANGE: Removal of getExperimentalStatus
coveo · Aug 1, 2024 · bfc43cf · bfc43cf
1 parent 8ff263b
commit bfc43cf
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 24 deletions.
diff --git a/src/resources/Organizations/Organization.ts b/src/resources/Organizations/Organization.ts
@@ -87,18 +87,9 @@ export default class Organization extends Resource {
         return this.api.get<any>(`${Organization.baseUrl}/${organizationId}/additionalinformation`);
     }
 
-    getExperimentalStatus(organizationId: string = API.orgPlaceholder) {
-        return this.api.get<boolean>(
-            `${Organization.baseUrl}/${organizationId}/machinelearning/orgconfiguration/servingExperimentAllowed`,
-        );
-    }
-
-    updateExperimentalStatus(isAllowed: boolean = false) {
+    updateExperimentalStatus(allowed: boolean = true) {
         return this.api.put<boolean>(
-            this.buildPath(
-                `${Organization.baseUrl}/${API.orgPlaceholder}/machinelearning/orgconfiguration/servingExperimentAllowed`,
-                {isAllowed},
-            ),
+            `${Organization.baseUrl}/${API.orgPlaceholder}/configuration/servingExperiment?allowed=${allowed}`,
         );
     }
 

diff --git a/src/resources/Organizations/OrganizationInterfaces.ts b/src/resources/Organizations/OrganizationInterfaces.ts
@@ -115,6 +115,9 @@ export interface OrganizationModel {
     readOnly: boolean;
     license?: LicenseModel;
     organizationStatusModel?: OrganizationsStatusModel;
+    configuration: {
+        servingExperimentAllowed: boolean;
+    };
 }
 
 export type AdditionalOrganizationField = 'status' | 'license' | string;

diff --git a/src/resources/Organizations/tests/Organizations.spec.ts b/src/resources/Organizations/tests/Organizations.spec.ts
@@ -251,31 +251,22 @@ describe('Organization', () => {
     });
 
     describe('experimental status', () => {
-        it('should make a GET call to the specific Organization url', () => {
-            const organizationToGetId = 'Organization-to-be-fetched';
-            organization.getExperimentalStatus(organizationToGetId);
-            expect(api.get).toHaveBeenCalledTimes(1);
-            expect(api.get).toHaveBeenCalledWith(
-                `${Organization.baseUrl}/${organizationToGetId}/machinelearning/orgconfiguration/servingExperimentAllowed`,
-            );
-        });
-
-        it('should make a PUT call to update experimental status with default false', () => {
+        it('should make a PUT call to update experimental status with default true', () => {
             organization.updateExperimentalStatus();
 
             expect(api.put).toHaveBeenCalledTimes(1);
             expect(api.put).toHaveBeenCalledWith(
-                `${Organization.baseUrl}/{organizationName}/machinelearning/orgconfiguration/servingExperimentAllowed?isAllowed=${false}`,
+                `${Organization.baseUrl}/{organizationName}/configuration/servingExperiment?allowed=true`,
             );
         });
 
         it('should make a PUT call to update experimental status with passed value', () => {
-            const isAllowed = true;
+            const isAllowed = false;
             organization.updateExperimentalStatus(isAllowed);
 
             expect(api.put).toHaveBeenCalledTimes(1);
             expect(api.put).toHaveBeenCalledWith(
-                `${Organization.baseUrl}/{organizationName}/machinelearning/orgconfiguration/servingExperimentAllowed?isAllowed=${true}`,
+                `${Organization.baseUrl}/{organizationName}/configuration/servingExperiment?allowed=false`,
             );
         });
     });