Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CBLIS storing and querying boolean value #762

Merged
merged 2 commits into from
Jun 9, 2015

Conversation

pasin
Copy link
Contributor

@pasin pasin commented Jun 9, 2015

  • Store boolean value in CBL database as JSON boolean value instead of number boolean value
  • Provide kCBLISCustomPropertyQueryBooleanWithNumber (Default is NO) to support querying the existing boolean number value.
  • If setting the kCBLISCustomPropertyQueryBooleanWithNumber property value to YES, when scanning the predicate for CBLQueryBuilder, CBLIS will replcate the original boolean predicate with an OR-compound predicate of the original predicate and the improvised number boolean predicate without parameterizing. For example, if the predicate is 'checked == YES', CBLIS will replace the predicate with 'checked == YES or checked == 1.
    CBLIS query with boolean value returns 0 result #756

mastohhh and others added 2 commits June 9, 2015 16:13
- Store boolean value in CBL database as JSON boolean value instead of number boolean value

- Provide kCBLISCustomPropertyQueryBooleanWithNumber (Default is NO) to support querying the existing boolean number value.

- If setting the kCBLISCustomPropertyQueryBooleanWithNumber property value to YES, when scanning the predicate for CBLQueryBuilder, CBLIS will replcate the original boolean predicate with an OR-compound predicate of the original predicate and the improvised number boolean predicate without parameterizing. For example, if the predicate is 'checked == YES', CBLIS will replace the predicate with 'checked == YES or checked == 1.

#756
@pasin pasin force-pushed the feature/issue_756_cblis_boolean_predicate branch from 1e7fa32 to 4d231e8 Compare June 9, 2015 09:25
snej added a commit that referenced this pull request Jun 9, 2015
…n_predicate

Fix CBLIS storing and querying boolean value

Fixes #756
@snej snej merged commit 9d9f799 into master Jun 9, 2015
@snej snej deleted the feature/issue_756_cblis_boolean_predicate branch June 9, 2015 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants