Try to connect when rechability reports not-reachable #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Attempt to connect to the remote url when the rechability reports not-reachable. If an offline error returns, bring the replicator offline. Otherwise, bring the replicator online. - Used request timeout of 10 seconds. - Added autoRetry parameter to CBLRemoteRequest to be able to enable/disable retry feature; set auto retry to NO when trying to check if the server is reachable nor not. - Extended NSURLErrorCannotConnectToHost, NSURLErrorCannotFindHost, and NSURLErrorNetworkConnectionLost to the CBLMisc.CBLIsOfflineError method. #536
| @@ -299,6 +299,9 @@ BOOL CBLIsOfflineError( NSError* error ) { | |||
| if ($equal(domain, NSURLErrorDomain)) | |||
| return code == NSURLErrorDNSLookupFailed | |||
| || code == NSURLErrorNotConnectedToInternet | |||
| || code == NSURLErrorCannotConnectToHost | |||
| || code == NSURLErrorCannotFindHost | |||
| || code == NSURLErrorNetworkConnectionLost | |||
There was a problem hiding this comment.
These error codes don't mean the device is offline, just that the server isn't reachable. I don't think it would be a good idea to have the replicator go offline if, say, the server URL has the wrong port number; this should be reported as an error.
- Add kCBLReplicatorOption_TrustReachability option. The default value is 'YES'. Also setting a value to the kCBLReplicatorOption_Network option will take precendence over and result to always 'Trust'. - If settings kCBLReplicatorOption_TrustReachability to NO, when the reachability reports offline, the replicator will try to connect to the host and see if it receives any offline related erros or not. - Rename mayGoOffline method to checkIfOffline. - Revert CBLMisc.CBLIsOfflineError and add checking NSURLErrorCannotConnectToHost and NSURLErrorNetworkConnectionLost directly to the checkIfOffline method. #536
|
@snej I push changes per code review and discussion. Please review it again when you have time. Thanks. |
snej
added a commit
that referenced
this pull request
Mar 25, 2015
…_alwaysoffline Try to connect when rechability reports not-reachable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac Application Reachability issue #536