Don't create SQLite FTS or RTree tables until needed #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows CBL to work with a SQLite build that doesn't include the fts3 or rtree modules (for example, a stock build of SQLCipher.) It probably also speeds up database creation somewhat. Also, I noticed we didn't have any unit tests for geo anymore, so I went back in time and restored the old one.
|
Updated the patch to handle the case where a geo/fts query is made before any geo/fts rows have been added to this index. (Initially this would fail because the tables didn't exist yet.) |
pasin
added a commit
that referenced
this pull request
Feb 18, 2015
Don't create SQLite FTS or RTree tables until needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows CBL to work with a SQLite build that doesn't include the fts3 or rtree modules
(for example, a stock build of SQLCipher.)
It probably also speeds up database creation somewhat.
Also, I noticed we didn't have any unit tests for geo anymore, so I went back in time and
restored the old one.