remove CBLDocument from database document cache when purged #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Merged as 3b389c7. |
ghost
mentioned this pull request
ghost
mentioned this pull request
Closed
Closed
pasin
added a commit
that referenced
this pull request
Mar 3, 2021
I have made two separate commits when updating Lite-Core: Before and After enabling version-vector. Here are summary of the changes: **Before enabling version-vector:** * Used `c4doc_getProperties` instead of `c4doc.selectedRev.body` and ensured to retain the body through the life of the document according to its selected revision. This has been done in CBLC4Document that wraps and retains C4Document object. * Moved `-encode:` method from `CBLMutableDocument` to `CBLDocument` itself as overriding is not needed anymore. * Used `c4db_getDoc` instead of `c4doc_get` as `c4doc_get` is semi-deprecated. * Used `C4DocContentLevel.kDocGetAll` when creating a conflicting doc in `CBLDatabase`’s `-resolveConflictInDocument:` as we need to select a conflicting revision. * Added another constructor in `CBLDocument` to be able to specify `C4DocContentLevel` when using `c4db_getDoc`. * Disabled some tests per the open issues. * Open issues: [CBL-1707](https://issues.couchbase.com/browse/CBL-1707), [CBL-1709](https://issues.couchbase.com/browse/CBL-1709), [CBL-1710](https://issues.couchbase.com/browse/CBL-1710). **After enabling version-vector:** * When calling `c4doc_resolveConflict`, always send `mergedFlags` so it will depend on LiteCore whether it wants to use the flags or not. * Simplified testConflictResolutionDefault. * Disabled failed tests per the open issues. * Open Issue: [CBL-1713](https://issues.couchbase.com/browse/CBL-1713), [CBL-1715](https://issues.couchbase.com/browse/CBL-1715). **Information about version vector and lite-core api changes by @snej** * [LiteCore Version Vector Progress Report](https://docs.google.com/document/d/1OwHqwctXNd6bGqkhlPx8jWvHDnjdyLK3YU0iQHCRrWQ) * [LiteCore Version Vector Progress Report #2](https://docs.google.com/document/d/1Wa5YaoPXgciGGVICY65JtiYhqhbeD64-tuptmliEGoA) * [LiteCore Version Vector Progress Report #3](https://docs.google.com/document/d/153s2oD5qdtYGBDNYtYH6_c0wyrHiKVXF-23uNyA8lJA) * [Information about c4db_getDoc and c4db_get](https://github.com/couchbase/couchbase-lite-core/blob/master/C/include/c4Document.h#L101-L122).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix to remove a purged document from the database cache that I submitted to the TouchDB-iOS project, including the fixes that you suggested in the old pull request.