Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1927 session cookie overwritten by the cookie in shared storage #1943

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

pasin
Copy link
Contributor

@pasin pasin commented Nov 1, 2017

Set request.HTTPShouldHandleCookies to NO so that the CBLHTTPLogic will not add the cookies from the shared cookie storage. Also we don’t actually use the shared cookie storage.

Set request.HTTPShouldHandleCookies to NO so that the CBLHTTPLogic will not add the cookies from the shared cookie storage. Also we don’t actually use the shared cookie storage.

#1927
@pasin pasin added the review label Nov 1, 2017
@pasin pasin requested a review from snej November 1, 2017 06:05
@pasin
Copy link
Contributor Author

pasin commented Nov 1, 2017

Another way to fix this is to remove this lines. @snej should the logic to set the cookies from the shared storage be removed as we don't use the shared cookie storage?

@pasin
Copy link
Contributor Author

pasin commented Nov 3, 2017

I think the fix is right. I'm merging this in myself.

@pasin pasin merged commit 0a777a8 into feature/2.0 Nov 3, 2017
@pasin pasin deleted the feature/2.0-fix-cookie-overwritten branch November 3, 2017 17:58
@pasin pasin removed the review label Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants