Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for encoding / decoding NSURL instances as properties of a CBLModel #439

Closed
mz2 opened this issue Sep 1, 2014 · 3 comments
Closed

Support for encoding / decoding NSURL instances as properties of a CBLModel #439

mz2 opened this issue Sep 1, 2014 · 3 comments
Assignees
@pasin
Labels
enhancement f: Model in progress
Milestone
1.1.0

Comments

@mz2
Copy link
Contributor

mz2 commented Sep 1, 2014

It would be nice to support encoding and decoding of NSURL instances as properties in a CBLModel (as it already anyway goes beyond the typical JSON encodable types).
@snej
Copy link
Contributor

snej commented Sep 1, 2014

That's a good idea. Very easy to implement too.

@jessliu jessliu modified the milestones: 1.1.0, Future Sep 3, 2014
@jessliu jessliu modified the milestones: 1.2.0, Future Sep 3, 2014
@pasin pasin added in progress and removed ready labels Sep 9, 2014
@pasin pasin self-assigned this Sep 9, 2014
pasin added a commit that referenced this issue Sep 9, 2014
@pasin
#439 Add NSURL support to the CBLModel property
8502443 
Implement NSURL support to the CBLModel property and update unit tests accordingly.
snej added a commit that referenced this issue Sep 9, 2014
@snej
Merge pull request #454 from couchbase/feature/issue_439
d8776f7 
#439 Add NSURL support to the CBLModel property
@pasin
Copy link
Contributor

pasin commented Sep 10, 2014

Closed as the feature has been merged into the master branch.

@pasin pasin closed this as completed Sep 10, 2014
@mz2
Copy link
Contributor Author

mz2 commented Sep 14, 2014

Whoa that was fast! Thanks, just to confirm this appears to work great with current head of the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pasin pasin

Labels
enhancement f: Model in progress
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
4 participants
@snej @mz2 @pasin @jessliu