Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing role appears to cause continuous push replication to stop [v1.4] #1649

Closed
npomfret opened this issue Mar 3, 2017 · 7 comments
Closed
Assignees
Milestone

Comments

@npomfret
Copy link

npomfret commented Mar 3, 2017

If I client attempts to edit a document for which they are not permission using roles i see the "missing role" error message in the sync gateway and iOS logs as you would expect. What appears to be happening after is that no more changes that the client makes are pushed to the sync gateway. It's as if the pull replication process stops completely. Is this intended behaviour?

Here are the logs: https://gist.github.com/npomfret/359800d530ef07b539fdbf52c9acdbbb

@pasin
Copy link
Contributor

pasin commented Mar 3, 2017

From the log, it seems like there is a bug when uploading the multipart document that doesn't ignore the status forbidden. Sending _bulk_docs seems to be able to handle that.

@npomfret
Copy link
Author

npomfret commented Mar 3, 2017

What do you mean? Is this a bug? Or am i doing something wrong. FYI - i'm only using the REST api.

@pasin
Copy link
Contributor

pasin commented Mar 3, 2017

I believe it's a bug in CBL.

@npomfret
Copy link
Author

npomfret commented Mar 6, 2017

Thanks @pasin

It occurs to me that it's becoming quite a serious problem. You see, if a client is offline they may not have the right information, and so may attempt to make changes to documents which they 'think' are allowed. But when that change hit's the sync gateway it gets rejected, because the SG is using more up to date information.

So my clients die - through no fault of there own, and through no programming error on my part.

pasin added a commit that referenced this issue Mar 9, 2017
Not treating 403 or forbidden error as an error when uploading multipart or non-multipart revision. This is inline with uploading bulk docs.

#1649
@pasin pasin self-assigned this Mar 9, 2017
@pasin
Copy link
Contributor

pasin commented Mar 9, 2017

Marked as a potential cross-platform error.

@djpongh djpongh added this to the 1.4.1 milestone Mar 10, 2017
@djpongh djpongh modified the milestones: 1.4.2, 1.4.1 Apr 7, 2017
@npomfret
Copy link
Author

Hi - has there been any progress on this issue?

@pasin
Copy link
Contributor

pasin commented May 23, 2017

It's still waiting for code review. #1657

@djpongh djpongh modified the milestones: 1.4.1, 1.4.2 Jun 1, 2017
@snej snej closed this as completed in c773bbe Jun 2, 2017
@snej snej removed the review label Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants