CBLVersion() incorrectly returns "(unofficial)" in official releases #1131
Comments
snej
added a commit
that referenced
this issue
Feb 19, 2016
The build variable CURRENT_PROJECT_VERSION, which gets overridden by the official server build script, didn't get passed through to the simulator builds done as part of our fat (device+simulator) build script. Updated BuildFatLibrary.sh to explicitly pass it, and two other build variables that also get set during official builds. Fixes #1131
snej
added a commit
that referenced
this issue
Feb 19, 2016
The build variable CURRENT_PROJECT_VERSION, which gets overridden by the official server build script, didn't get passed through to the simulator builds done as part of our fat (device+simulator) build script. Updated BuildFatLibrary.sh to explicitly pass it, and two other build variables that also get set during official builds. Fixes #1131
|
Latest build #588 is still showing zero. I looked in the master branch and don't see the changes in BuildFatLibrary.sh. |
|
I haven't committed the change yet, because I'm still waiting for you to code-review it (#1133). Sorry I forgot about this important detail when you came over earlier. |
|
Build 589 looks good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discovered in this forum thread, the result of calling
CBLVersion()in the official 1.2 release is@"1.2 (unofficial)". But only if you run it in the iOS simulator — on a device, or in a Mac OS app, you correctly get@"1.2.0 (build 112)".The cause of this is that the constant
CouchbaseLiteVersionNumberis 0.0 in the simulator builds. And that's because the build settingCURRENT_PROJECT_VERSIONhas its default value of0. The build script overrides it to the correct build number when invoking xcodebuild, but that's not taking effect when the simulator binaries are compiled. And that seems to be due to BuildFatLibrary.sh.The text was updated successfully, but these errors were encountered: