Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BORON] Part of CBL 5579 in order to facilitate VS on .NET Android #1993

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

borrrden
Copy link
Member

Cherry picked from d1d375b

This probably affects Java Android as well, but at least on lower API levels a native library without the lib prefix will not be automatically extracted in legacy packaging. So Android needs to look for libCouchbaseLiteVectorSearch while others continue looking for CouchbaseLiteVectorSearch. In the meantime added more logging to show details about the loading process.

Cherry picked from d1d375b

This probably affects Java Android as well, but at least on lower API levels a native library without the lib prefix will not be automatically extracted in legacy packaging.  So Android needs to look for libCouchbaseLiteVectorSearch while others continue looking for CouchbaseLiteVectorSearch.  In the meantime added more logging to show details about the loading process.
@borrrden borrrden requested a review from jianminzhao March 28, 2024 21:49
@cbl-bot
Copy link

cbl-bot commented Mar 28, 2024

Code Coverage Results:

Type Percentage
branches 69.75
functions 80.23
instantiations 36.8
lines 80.17
regions 76.76

@jianminzhao jianminzhao merged commit ab19634 into master Apr 8, 2024
9 checks passed
@jianminzhao jianminzhao deleted the fix/android_legacy_vs_extension branch April 8, 2024 15:55
jianminzhao added a commit that referenced this pull request May 23, 2024
CBL-5629: Update zlib to 1.3.1 (#2032)
CBL-5627: Update min MacOS version to 12.0 (#2033)
CBL-5539: Add an API to check if a vector index is trained or not (#2035)
CBL-5628: Update mbedtls to 2.28.8 (#2027)
374d485 Support latest vectorsearch (dev branch) and hybrid queries (#1980)
5c3c854 Lazy vector index updating (#1949)
CBL-5522: Port - N1QL Parser has exponential slowdown for redundant parentheses (#1984)
ab19634 Part of CBL 5579 in order to facilitate VS on .NET Android (#1993)
CBL-5507: Fix index-past-end in CookieStore (#1982)
CBL-5591: Binary Decoder to account for the new Logging object path (#1995)
294c3f8 Define _LIBCPP_REMOVE_TRANSITIVE_INCLUDES (#1987)
CBL-5438: DateTime standard format parser (#1977)
CBL-5498: Util changes for ConnectedClient (#1978)
CBL-5450: Remote rev KeepBody flag could be cleared accidentally
f8a8de2 Remove UWP builds from build scripts (#1954)
CBL-5425: Binary Encoder to encode the (Logging) object path (#1986)
CBL-4661: Fix ROUND_EVEN. (#1981)
jianminzhao added a commit that referenced this pull request Aug 26, 2024
CBL-5629: Update zlib to 1.3.1 (#2032)
CBL-5627: Update min MacOS version to 12.0 (#2033)
CBL-5539: Add an API to check if a vector index is trained or not (#2035)
CBL-5628: Update mbedtls to 2.28.8 (#2027)
374d485 Support latest vectorsearch (dev branch) and hybrid queries (#1980)
5c3c854 Lazy vector index updating (#1949)
CBL-5522: Port - N1QL Parser has exponential slowdown for redundant parentheses (#1984)
ab19634 Part of CBL 5579 in order to facilitate VS on .NET Android (#1993)
CBL-5507: Fix index-past-end in CookieStore (#1982)
CBL-5591: Binary Decoder to account for the new Logging object path (#1995)
294c3f8 Define _LIBCPP_REMOVE_TRANSITIVE_INCLUDES (#1987)
CBL-5438: DateTime standard format parser (#1977)
CBL-5498: Util changes for ConnectedClient (#1978)
CBL-5450: Remote rev KeepBody flag could be cleared accidentally
f8a8de2 Remove UWP builds from build scripts (#1954)
CBL-5425: Binary Encoder to encode the (Logging) object path (#1986)
CBL-4661: Fix ROUND_EVEN. (#1981)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants