CBL-5438: DateTime standard format parser #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now this points to the CBL-5438 Fleece branch, for sanity checks. |
borrrden
approved these changes
Mar 26, 2024
|
Code Coverage Results:
|
|
|
jianminzhao
added a commit
that referenced
this pull request
May 23, 2024
CBL-5629: Update zlib to 1.3.1 (#2032) CBL-5627: Update min MacOS version to 12.0 (#2033) CBL-5539: Add an API to check if a vector index is trained or not (#2035) CBL-5628: Update mbedtls to 2.28.8 (#2027) 374d485 Support latest vectorsearch (dev branch) and hybrid queries (#1980) 5c3c854 Lazy vector index updating (#1949) CBL-5522: Port - N1QL Parser has exponential slowdown for redundant parentheses (#1984) ab19634 Part of CBL 5579 in order to facilitate VS on .NET Android (#1993) CBL-5507: Fix index-past-end in CookieStore (#1982) CBL-5591: Binary Decoder to account for the new Logging object path (#1995) 294c3f8 Define _LIBCPP_REMOVE_TRANSITIVE_INCLUDES (#1987) CBL-5438: DateTime standard format parser (#1977) CBL-5498: Util changes for ConnectedClient (#1978) CBL-5450: Remote rev KeepBody flag could be cleared accidentally f8a8de2 Remove UWP builds from build scripts (#1954) CBL-5425: Binary Encoder to encode the (Logging) object path (#1986) CBL-4661: Fix ROUND_EVEN. (#1981)
jianminzhao
added a commit
that referenced
this pull request
Aug 26, 2024
CBL-5629: Update zlib to 1.3.1 (#2032) CBL-5627: Update min MacOS version to 12.0 (#2033) CBL-5539: Add an API to check if a vector index is trained or not (#2035) CBL-5628: Update mbedtls to 2.28.8 (#2027) 374d485 Support latest vectorsearch (dev branch) and hybrid queries (#1980) 5c3c854 Lazy vector index updating (#1949) CBL-5522: Port - N1QL Parser has exponential slowdown for redundant parentheses (#1984) ab19634 Part of CBL 5579 in order to facilitate VS on .NET Android (#1993) CBL-5507: Fix index-past-end in CookieStore (#1982) CBL-5591: Binary Decoder to account for the new Logging object path (#1995) 294c3f8 Define _LIBCPP_REMOVE_TRANSITIVE_INCLUDES (#1987) CBL-5438: DateTime standard format parser (#1977) CBL-5498: Util changes for ConnectedClient (#1978) CBL-5450: Remote rev KeepBody flag could be cleared accidentally f8a8de2 Remove UWP builds from build scripts (#1954) CBL-5425: Binary Encoder to encode the (Logging) object path (#1986) CBL-4661: Fix ROUND_EVEN. (#1981)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description copied from Fleece PR:
A proper parser for DateTime formats, rather than just parsing format string as a DateTime.
This has benefits such as additional flexibility in future, but also allows us to keep consistent with the strange "almost-ISO" date format we shipped with CBL-3.1, because keeping format as a DateTime does not allow us to optionally use colon or no-colon for Timezone offset (i.e. +0500 / +05:00).
I added in parsing for a "subset" of https://howardhinnant.github.io/date/date.html#to_stream_formatting, but it's not necessary and if anyone thinks we don't need it, happy to take it out. Think it's a lot better than the weird "1111-11-11T11:11......` format we copied from Server though.