Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate messages from pathEnd.go to msgs.go #378

Merged
merged 5 commits into from
Jan 21, 2021
Merged

migrate messages from pathEnd.go to msgs.go #378

merged 5 commits into from
Jan 21, 2021

Conversation

PrathyushaLakkireddy
Copy link
Contributor

@PrathyushaLakkireddy PrathyushaLakkireddy commented Jan 19, 2021 •
edited
Loading

Fixes : #368

@PrathyushaLakkireddy PrathyushaLakkireddy marked this pull request as ready for review January 19, 2021 10:01
@colin-axner colin-axner self-requested a review January 19, 2021 15:51
colin-axner
colin-axner reviewed Jan 20, 2021
View reviewed changes
relayer/msgs.go Outdated Show resolved Hide resolved
colin-axner
colin-axner reviewed Jan 20, 2021
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one nit. There are some merge conflicts as well with the pr I just merged

relayer/msgs.go Outdated Show resolved Hide resolved
colin-axner
colin-axner approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks!

@colin-axner colin-axner merged commit 07fad96 into cosmos:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate all pathEnd.go message construction functions to msgs.go and use Chain as the constructing type
2 participants
@PrathyushaLakkireddy @colin-axner