Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all pathEnd.go message construction functions to msgs.go and use Chain as the constructing type #368

Closed
colin-axner opened this issue Jan 14, 2021 · 1 comment · Fixed by #378
Labels
good first issue Good for newcomers T: Enhancement TYPE: Enhancement

Comments

@colin-axner
Copy link
Contributor

Currently message construction methods are being created by a PathEnd. This is unnecessary layering of information. We can move all these method construction to a msgs.go file. The PathEnd embedded in a chain is simply a pointer and not a list of pointers so trying to use a chain to house multiple path ends won't work and would require significant refactor. It'd be easier to simply create multiple chains (that refer to the same actual chain) but with different path end values. Moving the message construction functions to a chain constructor is required to fix #367 and would reduce potential bugs by enforcing that all message signers are the signer of the chain creating the message, rather than manually passing this argument in for every message construction call

@colin-axner colin-axner added the T: Enhancement TYPE: Enhancement label Jan 14, 2021
@colin-axner colin-axner added the good first issue Good for newcomers label Jan 14, 2021
@colin-axner
Copy link
Contributor Author

see #369 for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers T: Enhancement TYPE: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant