You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently message construction methods are being created by a PathEnd. This is unnecessary layering of information. We can move all these method construction to a msgs.go file. The PathEnd embedded in a chain is simply a pointer and not a list of pointers so trying to use a chain to house multiple path ends won't work and would require significant refactor. It'd be easier to simply create multiple chains (that refer to the same actual chain) but with different path end values. Moving the message construction functions to a chain constructor is required to fix #367 and would reduce potential bugs by enforcing that all message signers are the signer of the chain creating the message, rather than manually passing this argument in for every message construction call
The text was updated successfully, but these errors were encountered:
Currently message construction methods are being created by a
PathEnd
. This is unnecessary layering of information. We can move all these method construction to amsgs.go
file. ThePathEnd
embedded in a chain is simply a pointer and not a list of pointers so trying to use a chain to house multiple path ends won't work and would require significant refactor. It'd be easier to simply create multiple chains (that refer to the same actual chain) but with different path end values. Moving the message construction functions to a chain constructor is required to fix #367 and would reduce potential bugs by enforcing that all message signers are the signer of the chain creating the message, rather than manually passing this argument in for every message construction callThe text was updated successfully, but these errors were encountered: