Fix incorrect AccountPrefix bug and reinstate akash tests #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I opened an issue on the sdk |
|
I don't think the akash test goes into affect until after this is merged, tested locally that it passes |
fedekunze
approved these changes
Jan 14, 2021
|
@fedekunze is there lint issues introduced by new code in this pr? Otherwise I'd rather let it be, there's a long list of existing lint issues and I'd rather spend time on other issues |
|
I'm going to merge so folks can get back to testing the relayer. Any other requests can be done in followups and ideally would have an issue created for it |
| @@ -70,7 +70,7 @@ $ %s tx raw uc ibc-0 ibc-1 ibconeclient`, appName, appName)), | |||
| if err != nil { | |||
| return err | |||
| } | |||
| return sendAndPrint([]sdk.Msg{chains[src].PathEnd.UpdateClient(updateHeader, chains[src].MustGetAddress())}, | |||
| ibcexported "github.com/cosmos/cosmos-sdk/x/ibc/core/exported" | ||
| ) | ||
|
|
||
| // NOTE: we explicitly call 'MustGetAddress' before 'NewMsg...' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.