feat: implement misbehaviour detection #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misbehaviour detection was missing in the relayer, so it's been re-implemented such that on every MsgUpdateClient we compare the proposed consensus state to the trusted consensus state from the counterparty at the same height. If there is a deviation between the two a MsgSubmitMisbehaviour will be composed and broadcasted so that the light client is frozen.
jtieri
requested review from
jackzampolin,
boojamya and
mark-rushakoff
as code owners
|
Closes #750 |
agouin
reviewed
Mar 11, 2023
agouin
reviewed
Mar 11, 2023
agouin
reviewed
Mar 13, 2023
jonathanpberger
added a commit
to jonathanpberger/hermes
that referenced
this pull request
Nov 4, 2023
Misbehavior detection was added to the go-relayer in cosmos/relayer#1121 on March 13, 2023.
romac
pushed a commit
to informalsystems/hermes
that referenced
this pull request
Nov 8, 2023
Misbehavior detection was added to the go-relayer in cosmos/relayer#1121 on March 13, 2023. Co-authored-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misbehaviour detection was missing in the relayer, so it's been re-implemented such that on every
MsgUpdateClientwe compare the proposed consensus state to the trusted consensus state from the counterparty at the same height. If there is a deviation between the two aMsgSubmitMisbehaviourwill be composed and broadcasted so that the light client is frozen.Part of the goal here was to implement misbehaviour detection in a way that the code pieces involved are reusable, in the sense that they can be called from any
ChainProviderimplementation. Otherwise eachChainProviderimplementation would need to implement their own detection logic for every supported light client. To achieve this we need to expose theBinaryCodecwhich is an SDK interface type, this is required in order to callUnmarshalClientMessagefrom ibc-go