Re-add support for submitting misbehaviors

[jtieri]

This code used to be present but was removed when refactoring the codebase to account for the Provider abstraction.

We should get this added back and finalize the methods signature

relayer/relayer/provider/provider.go

Line 90 in 2bf5c32

SubmitMisbehavior( /*TODO TBD*/ ) (RelayerMessage, error)

Testing cases for this should be built out in the ibctest repo

[jtieri]

The code that used to be in place for submitting misbehaviors is here

relayer/relayer/misbehaviour.go

Lines 19 to 87 in 50534d4

	// checkAndSubmitMisbehaviour check headers from update_client tx events
	// against the associated light client. If the headers do not match, the emitted
	// header and a reconstructed header are used in misbehaviour submission to
	// the IBC client on the source chain.
	func checkAndSubmitMisbehaviour(src, counterparty *Chain, events map[string][]string) error {
	hdrs, ok := events[fmt.Sprintf("%s.%s", updateCliTag, headerTag)]
	if !ok {
	return nil
	}
	for i, hdr := range hdrs {
	clientIDs := events[fmt.Sprintf("%s.%s", updateCliTag, clientIDTag)]
	if len(clientIDs) <= i {
	return fmt.Errorf("emitted client-ids count is less than emitted headers count")
	}
	emittedClientID := clientIDs[i]
	if src.PathEnd.ClientID != emittedClientID {
	continue
	}
	hdrBytes, err := hex.DecodeString(hdr)
	if err != nil {
	return sdkerrors.Wrapf(err, "failed decoding hexadecimal string of header with client-id: %s",
	emittedClientID)
	}
	exportedHeader, err := clienttypes.UnmarshalHeader(src.Encoding.Marshaler, hdrBytes)
	if err != nil {
	return sdkerrors.Wrapf(err, "failed unmarshaling header with client-id: %s", emittedClientID)
	}
	emittedHeader, ok := exportedHeader.(*tmclient.Header)
	if !ok {
	return fmt.Errorf("emitted header is not tendermint type")
	}
	trustedHeader, err := counterparty.GetLightSignedHeaderAtHeight(emittedHeader.Header.Height)
	if err != nil {
	return err
	}
	if IsMatchingConsensusState(emittedHeader.ConsensusState(), trustedHeader.ConsensusState()) {
	continue
	}
	trustedHeader.TrustedValidators = emittedHeader.TrustedValidators
	trustedHeader.TrustedHeight = emittedHeader.TrustedHeight
	misbehaviour := tmclient.NewMisbehaviour(emittedClientID, emittedHeader, trustedHeader)
	msg, err := clienttypes.NewMsgSubmitMisbehaviour(emittedClientID, misbehaviour, src.MustGetAddress())
	if err != nil {
	return err
	}
	if err := msg.ValidateBasic(); err != nil {
	return err
	}
	res, success, err := src.SendMsg(msg)
	if err != nil {
	return err
	}
	if !success {
	return fmt.Errorf("submit misbehaviour tx failed: %s", res.RawLog)
	}
	src.Log(fmt.Sprintf("Submitted misbehaviour for emitted header with height: %d",
	emittedHeader.Header.Height))
	}
	return nil
	}

[ItsFunny]

When will it be finished

[jtieri]

Closed by #1121