Fix broken integration test(s) at 80d146a

[jtremback]

Currently, the integration tests are failing because the distribution module beginblocker is crashing, because the distribution module needs to be disabled on consumer chains. This would be permanently solved by #77, but it should also be possible to solve it temporarily by taking the distribution module beginblocker out of the beginblocker order in the exposed module manager (@rigelrozanski can maybe explain how to do this)

[mpoke]

Will be solved by #77.

[mpoke]

Related to #98

[mpoke]

See #98 (comment)

[sainoe]

Solved by #139 however the integration tests are still failing due to the states checker.
The error can be reproduced using this WIP MVCC branch.
@danwt

[danwt]

@sainoe thanks for the info. I checked out the WIP MVCC branch and ran the integration tests 3 times. Each time I get the same error

main.StartConsumerChainAction{consumerChain:0x1, providerChain:0x0, validators:[]main.StartChainValidator{main.StartChainValidator{id:0x2, allocation:0x2540be400, stake:0x1dcd6500}, main.StartChainValidator{id:0x0, allocation:0x2540be400, stake:0x1dcd6500}, main.StartChainValidator{id:0x1, allocation:0x2540be400, stake:0x1dcd6500}}}
2022/06/16 13:42:02 exit status 1
Error: unknown command "provider" for "query"

it's from this code

interchain-security/integration-tests/actions.go

Lines 289 to 300 in a28f86d

	func (s System) startConsumerChain(
	action StartConsumerChainAction,
	verbose bool,
	) {
	bz, err := exec.Command("docker", "exec", s.containerConfig.instanceName, s.chainConfigs[action.consumerChain].binaryName,
	"query", "provider", "consumer-genesis",
	s.chainConfigs[action.consumerChain].chainId,
	`--node`, s.getValidatorNode(action.providerChain, s.getValidatorNum(action.providerChain)),
	`-o`, `json`,
	).CombinedOutput()

I cannot actually replicate the failed states checker execution.

I don't know why this unknown command "provider" for "query" happens. The code to implement the query seems to exist

interchain-security/x/ccv/provider/client/cli/query.go

Lines 12 to 14 in a28f86d

	func NewQueryCmd() *cobra.Command {
	cmd := &cobra.Command{
	Use: types.ModuleName,

[danwt]

@sainoe the query problem in the previous comment seems to be fixed in

https://github.com/cosmos/interchain-security/tree/sainoe/mvcc-integration-tests-fix

but now I'm getting

main.AddIbcChannelAction{chainA:0x1, chainB:0x0, connectionA:0x0, portA:"consumer", portB:"provider", order:"ordered"}
addIBCChannel: 2022-06-16T14:03:04.163523Z  INFO ThreadId(01) using default configuration from '/root/.hermes/config.toml'
addIBCChannel: Error: missing chain for id (connection-0) in configuration file
{}
main.RelayPacketsAction{chain:0x0, port:"provider", channel:0x0}
2022/06/16 15:03:04 exit status 1
2022-06-16T14:03:04.336735Z  INFO ThreadId(01) using default configuration from '/root/.hermes/config.toml'
Error: supervisor error: channel provider/channel-0 on chain provider is not open
exit status 1

which still doesn't seem exactly the same.

[danwt]

Debugging, the first sendTokens on the consumer that occurs after starting the consumer chain but before relaying any packets between consumer and provider does not work as expected

interchain-security/integration-tests/steps.go

Lines 128 to 143 in 80d146a

	{
	action: SendTokensAction{
	chain: 1,
	from: 0,
	to: 1,
	amount: 1,
	},
	state: State{
	1: ChainState{
	ValBalances: &map[uint]uint{
	0: 9999999999,
	1: 10000000001,
	},
	},
	},
	},

Leads to

main.SendTokensAction{chain:0x1, from:0x0, to:0x1, amount:0x1}
"actual state"
{1: {ValBalances: {0: 10000000000,
                   1: 10000000000},
     Proposals:   nil,
     ValPowers:   nil}}
"model state"
{1: {ValBalances: {0: 9999999999,
                   1: 10000000001},
     Proposals:   nil,
     ValPowers:   nil}}
2022/06/26 14:21:47 actual state (-) not equal to model state (+):  {
  1: {
   ValBalances: {
-   0: 10000000000,
-   1: 10000000000,
+   0: 9999999999,
+   1: 10000000001,
   },
   Proposals: nil,
   ValPowers: nil,
  },
 }
exit status 1

raised here

interchain-security/integration-tests/main.go

Line 63 in 80d146a

log.Fatal(`actual state (-) not equal to model state (+): ` + pretty.Compare(actualState, modelState))

[danwt]

Closed as not fine grained enough. See new issues

• Integration test fails at 80d146a #168
• Integration test driver is incorrect. #167