Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test driver is incorrect. #167

Closed
danwt opened this issue Jun 26, 2022 · 0 comments
Closed

Integration test driver is incorrect. #167

danwt opened this issue Jun 26, 2022 · 0 comments
Assignees
@danwt
Labels
scope: testing Code review, testing, making sure the code is following the specification. type: bug Issues that need priority attention -- something isn't working

Comments

@danwt
Copy link
Contributor

danwt commented Jun 26, 2022 •
edited
Loading

The driver is incorrect. The dockerised commands fail, see this comment

#79 (comment)

This issue can be closed when the driver is correct.

Note, this is not the same as the test itself failing. See

for that.
@danwt danwt added type: bug Issues that need priority attention -- something isn't working scope: testing Code review, testing, making sure the code is following the specification. labels Jun 26, 2022
@danwt danwt self-assigned this Jun 26, 2022
@danwt danwt moved this to Todo in Replicated Security Jun 26, 2022
@danwt danwt moved this from Todo to In Progress in Replicated Security Jun 26, 2022
This was referenced Jun 26, 2022
Closed
Merged
@danwt danwt moved this from In Progress to Waiting for review in Replicated Security Jun 26, 2022
danwt added a commit that referenced this issue Jun 29, 2022
@danwt
Fix integration test driver #167 (#166)
deee1da 
* go mod replace

* main use fatalf log

* Apply changes from 1e2ad61

* go mod, actions

Co-authored-by: Daniel <danwtisdall@gmail.com>
@danwt danwt closed this as completed Jun 29, 2022
Repository owner moved this from Waiting for review to Done in Replicated Security Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danwt danwt

Labels
scope: testing Code review, testing, making sure the code is following the specification. type: bug Issues that need priority attention -- something isn't working
Projects
No open projects
Replicated Security
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danwt