Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICS 2: Consensus Verification #20
ICS 2: Consensus Verification #20
Changes from 26 commits
bd3f466
22a53a6
bc02fbb
06969cf
822d40d
536299d
7b88a58
d646f3f
7be1fc0
6cf8a45
ad95c82
5217fc7
d6eecfc
5778915
6662828
47c345c
dfe5366
de89aa8
946a881
e35778a
5e7581e
6fa0cb0
0ecd41b
b4582b3
a1d6fee
784ecc6
36c2245
e2bcf68
d156573
c59d7d3
f6c5174
d477958
384cef2
20ab792
308d046
0650090
bb8dfd6
d294123
76bde63
d425538
4fc5bcd
e3bafba
8847b89
2c37fb5
6adcd74
6cd10c9
0f651a8
34a302f
b9e3d79
fe18de8
bedd1fc
da0da4c
e8e560c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ICS23 does not mention pubkey (at least currently)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by this sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great example! Do you think we can use at least two or three-letter variable names? It would make it easier to read. e.g. -
Hdr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not clear what LogStore is...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change the example to a simple KVStore, which seems more appropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be confused here, but are
store
andstate
supposed to be the same thing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, fixed!