ICS 2: Consensus Verification #20

mossid · 2019-02-26T16:24:32Z

Closes: #25

spec/ics-3-ibc-semantics/README.md

cwgoes · 2019-03-04T13:58:17Z

Thanks @mossid - this looks more like an implementation spec than a protocol spec, let's see if we can separate concerns (or decide which this will be). Further discussion here: #23.

cwgoes · 2019-03-05T14:21:34Z

The first part of this could be a protocol specification, perhaps - #25.

cwgoes · 2019-03-05T16:45:10Z

Per discussion with @mossid - to be split up into #25 and an implementation spec.

cwgoes

I think we should probably omit connections and channels from the scope of this ICS, and focus only on consensus requirements, notably:

More formally specifying the four properties in terms of the sets of accepted headers (the properties themselves seem accurate to me)
Rename "block" to "header" or something (there's not necessarily a need for headers to correspond to blocks)
Provide examples of "headers" for Tendermint-esque blockchains, "headers" for trivial IBC sources (just a signing key), their verification algorithms

spec/ics-2-consensus-requirements/README.md

cwgoes · 2019-03-12T14:33:02Z

spec/ics-2-consensus-requirements/README.md

+
+### Example Implementation
+
+An example blockchain `B` is run by a single operator. If a block is signed by the operator, then it is valid. `B` contains `KVStore`, which is a mapping from `[byte]` to  `[byte]`. 


Good example - I find the pseudocode a bit confusing though, can we make it a bit more like the ICS 1 example?

spec/ics-2-consensus-requirements/README.md

Co-Authored-By: mossid <torecursedivine@gmail.com>

cwgoes · 2019-05-21T08:50:22Z

spec/ics-2-consensus-verification/README.md

+function freezeClient(id, header1, header2)
+  assert(!get(freezekey(id)))
+  stored = get(storekey(id))
+  // TODO


What is "TODO"? We just need to mark the client as frozen.

cwgoes · 2019-05-21T08:50:48Z

I think we should actually specify the keys being used.

cwgoes · 2019-05-21T09:43:20Z

This also still needs to be reformatted per #84.

cwgoes

Please see unaddressed comments (look at the diff view).

cwgoes · 2019-05-21T09:55:31Z

spec/ics-2-consensus-verification/README.md

+
+This standard specifies the properties that consensus algorithms of chains implementing IBC are
+expected to satisfy. The properties are needed for efficient and safe verification in the higher
+level protocol abstractions. The algorithm which uses these properties to verify substates of


^ should be defined

spec/ics-2-consensus-verification/README.md

cwgoes · 2019-05-21T09:56:00Z

spec/ics-2-consensus-verification/README.md

+### Motivation
+
+Light clients are the verification method of IBC protocol. One chain can track another chain's
+updating state with a light client pointing to that chain. This standard formalises the common


still needs to be addressed

spec/ics-2-consensus-verification/README.md

cwgoes · 2019-05-21T09:59:15Z

spec/ics-2-consensus-verification/README.md

+##### Preliminaries
+
+`newID` is a function which generates a new `Identifier` for a `LightClient`, which MAY depending
+on the `Header`. The behaviour of `newID` is implementation specific. Possible implementations are:


still needs to be addressed

spec/ics-2-consensus-verification/README.md

cwgoes · 2019-05-21T09:59:37Z

spec/ics-2-consensus-verification/README.md

+##### Update
+
+Updating `LightClient` is done by submitting a new `Header`. The `Identifier` is used to point the
+stored `LightClient` that the logic will update. When the new `Header` is verifiable with


still needs to be addressed

Co-Authored-By: Christopher Goes <cwgoes@pluranimity.org> Co-Authored-By: gamarin2 <gautier@tendermint.com>

… joon/ics-3-ibc-semantics

cwgoes · 2019-05-22T12:48:28Z

Please fix check_dependencies and check_sections CI failures (ref #84).

You can ignore check_syntax and check_links for now.

cwgoes · 2019-05-22T13:17:41Z

Merge master and then check_links should also pass now (you might need to fix a few links).

cwgoes · 2019-05-22T19:24:29Z

I think there needs to be some more work on unification with ICS 3 / 4 / 25, but that can happen in a follow-up PR.

mossid added 2 commits February 26, 2019 14:30

add README

bd3f466

in progress

22a53a6

mossid added tao Transport, authentication, & ordering layer. wip Issues or pull requests which are in progress. labels Feb 26, 2019

in progress

bc02fbb

jackzampolin reviewed Feb 26, 2019

View reviewed changes

spec/ics-3-ibc-semantics/README.md Outdated Show resolved Hide resolved

mossid added 2 commits February 27, 2019 16:57

latex -> md

06969cf

rename folder

822d40d

mossid changed the title ~~WIP: IBC Connection Semantics~~ WIP: Connection Semantics Feb 27, 2019

mossid added 3 commits February 27, 2019 19:04

rm appendex, do todos

536299d

add lightclients, port from docs/spec/ibc

7b88a58

add impl

d646f3f

format with ics1

7be1fc0

mossid changed the title ~~WIP: Connection Semantics~~ WIP: Consensus Requirements Mar 5, 2019

mossid changed the title ~~WIP: Consensus Requirements~~ WIP: ICS 2: Consensus Requirements Mar 5, 2019

mossid added 3 commits March 6, 2019 11:39

fix grammar

6cf8a45

add example

ad95c82

copy summary from docs/ibc, add motivation

5217fc7

mossid changed the title ~~WIP: ICS 2: Consensus Requirements~~ R4R: ICS 2: Consensus Requirements Mar 6, 2019

mossid added ready-for-review Pull requests which are ready for review. and removed wip Issues or pull requests which are in progress. labels Mar 6, 2019

rename folder

d6eecfc

mossid marked this pull request as ready for review March 6, 2019 12:42

cwgoes reviewed Mar 12, 2019

View reviewed changes

cwgoes and others added 3 commits March 14, 2019 04:18

Update spec/ics-2-consensus-requirements/README.md

5778915

Co-Authored-By: mossid <torecursedivine@gmail.com>

Update spec/ics-2-consensus-requirements/README.md

6662828

Co-Authored-By: mossid <torecursedivine@gmail.com>

address comments in progress

47c345c

mossid added the wip Issues or pull requests which are in progress. label May 20, 2019

apply ICS25/ICS1

d294123

cwgoes reviewed May 21, 2019

View reviewed changes

cwgoes added ready-for-review Pull requests which are ready for review. and removed wip Issues or pull requests which are in progress. labels May 21, 2019

cwgoes suggested changes May 21, 2019

View reviewed changes

mossid and others added 6 commits May 21, 2019 14:32

Apply suggestions from code review

76bde63

Co-Authored-By: Christopher Goes <cwgoes@pluranimity.org> Co-Authored-By: gamarin2 <gautier@tendermint.com>

Merge branch 'master' into joon/ics-3-ibc-semantics

d425538

Merge branch 'master' into joon/ics-3-ibc-semantics

4fc5bcd

address comments in progress

e3bafba

address comments in progress

8847b89

Merge branch 'joon/ics-3-ibc-semantics' of github.com:cosmos/ics into…

2c37fb5

… joon/ics-3-ibc-semantics

mossid added 2 commits May 22, 2019 15:01

in progres

6adcd74

address comments

6cd10c9

mossid added 7 commits May 22, 2019 15:40

reformat, fix links

0f651a8

Merge branch 'master' into joon/ics-3-ibc-semantics

34a302f

fix link section

b9e3d79

fix links

fe18de8

fix link

bedd1fc

fix section

da0da4c

fix script to test only readmes

e8e560c

cwgoes approved these changes May 22, 2019

View reviewed changes

cwgoes merged commit e099425 into master May 22, 2019

cwgoes deleted the joon/ics-3-ibc-semantics branch May 22, 2019 19:25

cwgoes mentioned this pull request May 22, 2019

ICS 2 followup #99

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ICS 2: Consensus Verification #20

ICS 2: Consensus Verification #20

mossid commented Feb 26, 2019 •

edited

Loading

cwgoes commented Mar 4, 2019 •

edited

Loading

cwgoes commented Mar 5, 2019 •

edited

Loading

cwgoes commented Mar 5, 2019

cwgoes left a comment

cwgoes Mar 12, 2019

cwgoes May 21, 2019

cwgoes commented May 21, 2019

cwgoes commented May 21, 2019

cwgoes left a comment •

edited

Loading

cwgoes May 21, 2019

cwgoes May 21, 2019

cwgoes May 21, 2019

cwgoes May 21, 2019

cwgoes commented May 22, 2019 •

edited

Loading

cwgoes commented May 22, 2019 •

edited

Loading

cwgoes commented May 22, 2019


		### Example Implementation

		An example blockchain `B` is run by a single operator. If a block is signed by the operator, then it is valid. `B` contains `KVStore`, which is a mapping from `[byte]` to `[byte]`.

ICS 2: Consensus Verification #20

ICS 2: Consensus Verification #20

Conversation

mossid commented Feb 26, 2019 • edited Loading

cwgoes commented Mar 4, 2019 • edited Loading

cwgoes commented Mar 5, 2019 • edited Loading

cwgoes commented Mar 5, 2019

cwgoes left a comment

Choose a reason for hiding this comment

cwgoes Mar 12, 2019

Choose a reason for hiding this comment

cwgoes May 21, 2019

Choose a reason for hiding this comment

cwgoes commented May 21, 2019

cwgoes commented May 21, 2019

cwgoes left a comment • edited Loading

Choose a reason for hiding this comment

cwgoes May 21, 2019

Choose a reason for hiding this comment

cwgoes May 21, 2019

Choose a reason for hiding this comment

cwgoes May 21, 2019

Choose a reason for hiding this comment

cwgoes May 21, 2019

Choose a reason for hiding this comment

cwgoes commented May 22, 2019 • edited Loading

cwgoes commented May 22, 2019 • edited Loading

cwgoes commented May 22, 2019

mossid commented Feb 26, 2019 •

edited

Loading

cwgoes commented Mar 4, 2019 •

edited

Loading

cwgoes commented Mar 5, 2019 •

edited

Loading

cwgoes left a comment •

edited

Loading

cwgoes commented May 22, 2019 •

edited

Loading

cwgoes commented May 22, 2019 •

edited

Loading