Replace check_header_and_update_state with an architecture similar to ibc-go
#584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
+ Coverage 72.93% 73.19% +0.26%
==========================================
Files 126 125 -1
Lines 15725 15660 -65
==========================================
- Hits 11469 11463 -6
+ Misses 4256 4197 -59
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
plafer
changed the title
check_{header,misbehaviour}_and_update_state with a similar architecture of ibc-gocheck_header_and_update_state with a similar architecture of ibc-go
plafer
changed the title
check_header_and_update_state with a similar architecture of ibc-gocheck_header_and_update_state with an architecture similar to ibc-go
|
Created #600; I won't implement in this PR but it's a very desirable feature which we should have. |
…our.rs Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
…ient.rs Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
…our.rs Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
plafer
commented
Apr 12, 2023
plafer
commented
Apr 12, 2023
…ient.rs Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
|
@ancazamfir I will wait for your approval as well before merging |
ancazamfir
approved these changes
Apr 13, 2023
7 tasks
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
…to ibc-go (#584) * fix * changelog * verify_header contains a FIXME to double check * fix header.trusted_next_validator_set hash bug * fmt * remove bad comment * add timestamp monotonicity checks to `verify_header()` * clean up verify_header * add revision number check in verify_header * header height extra check * clarifying comment * check_misbehaviour_header scaffolding * remove duplicate methods * verify_misbehaviour done as ibc-go * fix chain ID before commit verification * finish verify_misbehavior * `check_for_misbehaviour` header variant implementation * check_for_misbehaviour, misbehaviour variant * monotonicity of timestamps in update_client * update_state_on_misbehaviour * implement update_state in tendermint light client * cleanup `map_err`s * Rename MsgUpdateClient::client_message * impl raw misbehaviour -> MsgUpdateClient * change updateClientKind enum * move misbehaviour tests to update_client * move misbehaviour type url * remove misbehaviour msg and handler * update_client::validate * implement part of update_client::execute * separate events emitted * finish update_client::execute * remove TODO * implement mock client state * fix mockclientstate * fix event created on update_client * fix mock * fix mock * test var names * fix parts of the problem with test * fix test * clippy * remove old methods * clean Misbehaviour::new() * cleanup unused * move `update_client` method to submodule * move misbehaviour to submodule * move implementation to function * move implementation to function * changelog * add clarifying comment * fmt * Update crates/ibc/src/clients/ics07_tendermint/client_state/misbehaviour.rs Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update crates/ibc/src/clients/ics07_tendermint/client_state/update_client.rs Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * Update crates/ibc/src/clients/ics07_tendermint/client_state/misbehaviour.rs Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * fix misbehaviour ctor * improve documentation around `UpdateKind` * fmt * remove unused misbehaviour trait * fix misbehaviour header checks * Update crates/ibc/src/clients/ics07_tendermint/client_state/update_client.rs Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com> * fix test after merge --------- Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing the new API, I found several bugs. I implicitly fix those by not re-introducing them in the new API implementation.
Main issue:
Closes: #535
Bugs fixed:
Closes: #583
Closes: #585
Closes: #589
Closes: #598
Closes: #601
Description
verify_client_messagecheck_for_misbehaviourupdate_state_on_misbehaviourupdate_stateupdate_client::validatecallsclient_state.verify_client_message, similar to here in ibc-goupdate_client::executecallsclient_state.{check_for_misbehaviour, update_state_on_misbehaviour, update_state}, similar to here in ibc-goClientState::{check_header_and_update_state}andClientState::{check_misbehaviour_and_update_state}, and all unusedwith_*functionsmisbehaviour::{validate, execute}TmMisbehaviour::new(); this should be a light constructor.MsgUpdateClientMsgSubmitMisbehaviourandMsgUpdateClientare merged into the "new"MsgUpdateClientTryFrom<RawMsgSubmitMisbehaviour> for MsgUpdateClientTryFrom<Any> for MsgEnvelopeMsgUpdateClient.headertoMsgUpdateClient.client_message, and addupdate_kindenum fieldPR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.