Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misbehaviour: wrong timestamp being used in trusting period checks #590

Closed
plafer opened this issue Mar 31, 2023 · 1 comment
Closed

Misbehaviour: wrong timestamp being used in trusting period checks #590

plafer opened this issue Mar 31, 2023 · 1 comment
Assignees
Labels
A: bug Admin: something isn't working

Comments

@plafer
Copy link
Contributor

plafer commented Mar 31, 2023

In checking for misbehaviour, we use host_timestamp() as the timestamp used in “trusting period checks”. This is not the timestamp we want to be using though, since this gives the timestamp associated with the latest “trusted consensus state”, whereas we want to be using the timestamp of the header we’re processing.

Equivalent in ibc-go (assuming ctx.BlockTime() is the height of the header being processed, which I think it is).

@plafer plafer added the A: bug Admin: something isn't working label Mar 31, 2023
@plafer
Copy link
Contributor Author

plafer commented May 1, 2023

This is not a bug; I think this was a misunderstanding of mine while doing #584.

@plafer plafer closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant