Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error todo!()s wherever the tendermint client calls consensus_state #435

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

Farhad-Shabani
Copy link
Member

Closes: #403


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani self-assigned this Feb 15, 2023
@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review February 15, 2023 17:48
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 62.21% // Head: 62.19% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (641f3e1) compared to base (0f3e03f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   62.21%   62.19%   -0.03%     
==========================================
  Files         131      131              
  Lines       17789    17795       +6     
==========================================
  Hits        11068    11068              
- Misses       6721     6727       +6     
Impacted Files Coverage Δ
...s/ibc/src/clients/ics07_tendermint/client_state.rs 45.42% <0.00%> (-0.22%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@plafer plafer merged commit d2435e6 into main Feb 15, 2023
@plafer plafer deleted the farhad/remove-todos branch February 15, 2023 18:17
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
…ate` (#435)

* Fix error todos for tendermint client

* Fix changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove todo!()s for tendermint ClientState
2 participants