Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove todo!()s for tendermint ClientState #403

Closed
plafer opened this issue Feb 8, 2023 · 0 comments · Fixed by #435
Closed

Remove todo!()s for tendermint ClientState #403

plafer opened this issue Feb 8, 2023 · 0 comments · Fixed by #435
Assignees
@Farhad-Shabani
Labels
A: critical Admin: critical or Important A: good-first-issue Admin: good for newcomers A: urgent Admin: high priority issue O: security Objective: aims to enhance security and improve safety
Milestone
v0.29.0

Comments

@plafer
Copy link
Contributor

plafer commented Feb 8, 2023

There are 3 todo!()s to be removed (one, two and three).
@plafer plafer added A: good-first-issue Admin: good for newcomers A: urgent Admin: high priority issue A: critical Admin: critical or Important O: security Objective: aims to enhance security and improve safety labels Feb 8, 2023
@plafer plafer added this to the v0.29.0 milestone Feb 10, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Feb 15, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Farhad-Shabani Farhad-Shabani

Labels
A: critical Admin: critical or Important A: good-first-issue Admin: good for newcomers A: urgent Admin: high priority issue O: security Objective: aims to enhance security and improve safety
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.29.0
Development

Successfully merging a pull request may close this issue.

Fix error todo!()s wherever the tendermint client calls consensus_state cosmos/ibc-rs
2 participants
@plafer @Farhad-Shabani