Fix counterparty channel id unwrap #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plafer
added a commit
that referenced
this pull request
Nov 7, 2022
* add failing test * bug fix * changelog
plafer
added a commit
that referenced
this pull request
Nov 9, 2022
* chan open init refactored * fmt * chan open init minor reorg * chan_open_try: apply naming convention * inline proof verification in chan_open_try * remove use of `Proofs` in MsgChannelOpenTry * Fix counterparty channel id unwrap (#220) * add failing test * bug fix * changelog * fix test compilation * ChanOpenAck msg update * refactor chan_open_ack * refactor mut * ChanOpenConfirm refactor msg * refactor chan_open_confirm * chan_close_init handler refactor * chan_close_confirm refactor * changelog * chan_open_init ctx_a
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* add failing test * bug fix * changelog
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* chan open init refactored * fmt * chan open init minor reorg * chan_open_try: apply naming convention * inline proof verification in chan_open_try * remove use of `Proofs` in MsgChannelOpenTry * Fix counterparty channel id unwrap (#220) * add failing test * bug fix * changelog * fix test compilation * ChanOpenAck msg update * refactor chan_open_ack * refactor mut * ChanOpenConfirm refactor msg * refactor chan_open_confirm * chan_close_init handler refactor * chan_close_confirm refactor * changelog * chan_open_init ctx_a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #219
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.