Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify_channel_proofs must not unwrap counterparty channel id #219

Closed
5 tasks done
plafer opened this issue Nov 4, 2022 · 0 comments · Fixed by #220
Closed
5 tasks done

verify_channel_proofs must not unwrap counterparty channel id #219

plafer opened this issue Nov 4, 2022 · 0 comments · Fixed by #220
Assignees
@plafer
Labels
A: bug Admin: something isn't working
Milestone
v0.22.0

Comments

@plafer
Copy link
Contributor

plafer commented Nov 4, 2022

Summary of Bug

This unwrap() is done on user input (i.e. the channel_end found in a message); a malformed message could crash the host chain.

Version

v0.21.1

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@plafer plafer added the A: bug Admin: something isn't working label Nov 4, 2022
@plafer plafer added this to the v0.22.0 milestone Nov 4, 2022
@plafer plafer self-assigned this Nov 4, 2022
@plafer plafer mentioned this issue Nov 4, 2022
Merged
7 tasks
@plafer plafer mentioned this issue Dec 13, 2022
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plafer plafer

Labels
A: bug Admin: something isn't working
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging a pull request may close this issue.

Fix counterparty channel id unwrap cosmos/ibc-rs
1 participant
@plafer