imp(ibc-testkit): deprecate MockContext multiple init methods
#1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnbguy
changed the title
MockContext multiple init methods
rnbguy
force-pushed
the
1042-deprecate-mockcontext-new-methods
branch
from
ed8e305
to
59332d7
Compare
rnbguy
changed the title
MockContext multiple init methodsMockContext multiple init methods
Farhad-Shabani
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Thank you @rnbguy . I just made a bit of trim and removed redundant method calls.
|
Thanks @Farhad-Shabani. I have merged it on |
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* deprecate default arg init methods in MockContext * refactor tests * add changelog * chore: trim redundant method calls, opting for default values --------- Co-authored-by: Farhad Shabani <farhad.shabani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1042
Description
Removes multiple default initializers from
MockContextand refactors the existing tests.PR author checklist:
unclog.docs/).mainReviewer checklist:
Files changedin the GitHub PR explorer.