imp(ibc-testkit): Deprecate MockContext::new* methods and their uses in favor of MockContextConfig

[rnbguy]

Bug Summary

Rust doesn't have default arguments in methods. So MockContext has two methods that allow initialization with default arguments in a hacky way.

We introduced MockContextConfig earlier to adopt the builder pattern.

But our tests are yet to be refactored to use MockContextConfig over MockContext::new.

Details

The following methods need to be deprecated

ibc-rs/ibc-testkit/src/testapp/ibc/core/types.rs

Lines 186 to 191 in d5e8314

	pub fn new(
	host_id: ChainId,
	host_type: HostType,
	max_history_size: u64,
	latest_height: Height,
	) -> Self {

ibc-rs/ibc-testkit/src/testapp/ibc/core/types.rs

Lines 244 to 249 in d5e8314

	pub fn new_with_validator_history(
	host_id: ChainId,
	host_type: HostType,
	validator_history: &[Vec<TestgenValidator>],
	latest_height: Height,
	) -> Self {

in favor of

ibc-rs/ibc-testkit/src/fixtures/core/context.rs

Lines 17 to 40 in d5e8314

	/// Configuration of the `MockContext` type for generating dummy contexts.
	#[derive(Debug, TypedBuilder)]
	#[builder(build_method(into = MockContext))]
	pub struct MockContextConfig {
	#[builder(default = HostType::Mock)]
	host_type: HostType,
	host_id: ChainId,
	#[builder(default = Duration::from_secs(DEFAULT_BLOCK_TIME_SECS))]
	block_time: Duration,
	// may panic if validator_set_history size is less than max_history_size + 1
	#[builder(default = 5)]
	max_history_size: u64,
	#[builder(default, setter(strip_option))]
	validator_set_history: Option<Vec<Vec<TestgenValidator>>>,
	latest_height: Height,
	#[builder(default = Timestamp::now())]
	latest_timestamp: Timestamp,
	}

Version

till v0.49.1