Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ibc port router for app callbacks #6314

Closed
wants to merge 51 commits into from
Closed

Commits on May 15, 2024

  1. Configuration menu
    Copy the full SHA
    845e45f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db5cddf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    385674a View commit details
    Browse the repository at this point in the history
  4. chore: add comment

    damiannolan committed May 15, 2024
    Configuration menu
    Copy the full SHA
    5c861f4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9d4d2ea View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    90fe8ae View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fc309f6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d0f85db View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    588ff66 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    8bc82f6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f883d68 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c5eef93 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e626c7b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    45896aa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    20326d4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3714960 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b2df2f3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b295949 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2f5116e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    16a88b4 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    67e4b5f View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3db1613 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    07e8b1c View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    4214201 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    9610871 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    ef6e063 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf339f2 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    4f8d319 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. (chore): remove capabilities from channel handsake (#7009)

    * not working yet
    
    * More tests fixed.
    
    * added message error
    
    * commented out tests
    
    * Wire approuter to e2e testing simapp
    
    * Delete obsolete tests
    
    * remove possibly unneeded call
    
    * Removed tests no longer needed
    
    * test: fix commented/removed tests
    
    ---------
    
    Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com>
    bznein and colin-axner authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    a4a7bdd View commit details
    Browse the repository at this point in the history
  2. Adding updates to composite router and scaffolding for LegacyIBCModule (

    #7010)
    
    * chore: adding updates to composite router and scaffolding for IBCLegacyModule
    
    * chore: support construction of LegacyIBCModules over consecutive calls to AddRoute
    
    * chore: removed ack handhsake impl
    
    * chore: fix linter
    
    * chore: lint
    
    * Linter
    
    * chore: addressing PR feedback
    
    * chore: routeToLegacyModule returns a single item
    
    * Update modules/core/05-port/types/router_v2.go
    
    * Update modules/core/05-port/types/router_v2.go
    
    * Update modules/core/05-port/types/router_v2.go
    
    * chore: fix errors from merge conflict
    
    ---------
    
    Co-authored-by: bznein <nikolas.degiorgis@interchain.io>
    Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com>
    3 people authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    832a0fc View commit details
    Browse the repository at this point in the history
  3. Rename IBCModule to ClassicIBCModule (#7015)

    * chore: adding updates to composite router and scaffolding for IBCLegacyModule
    
    * chore: support construction of LegacyIBCModules over consecutive calls to AddRoute
    
    * chore: removed ack handhsake impl
    
    * chore: fix linter
    
    * chore: lint
    
    * Linter
    
    * chore: addressing PR feedback
    
    * chore: rename IBCModule to ClassicIBCModule and add new IBCModule interface
    
    * fix: e2e for fee wrapped channels
    
    ---------
    
    Co-authored-by: bznein <nikolas.degiorgis@interchain.io>
    Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com>
    3 people authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    d701aa2 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    9565e36 View commit details
    Browse the repository at this point in the history
  2. fix: tests

    colin-axner committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3eaf2ce View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Add Wrap/Unwrap Interfaces and implement OnChanOpenInit (#7059)

    * chore: adding wrapping functions to ics29
    
    * chore: added docstring to VersionWrapper interface
    
    * chore: fix linter
    
    * refactor: use unsafe unwrap func in OnChanOpenInit
    
    * chore: fixing wiring in app.go and fee tests
    
    * fix: fee middleware tests
    
    * fix: ics27 controller tests
    
    * wip: debugging callbacks
    
    * chore: fix linter
    
    * chore: fix miswiring in callbacks module
    
    * chore: modifications to binary simapp
    
    * chore: do not unwrap a version if it is an empty string
    
    * Update modules/apps/27-interchain-accounts/controller/ibc_middleware.go
    
    * Apply suggestions from code review
    
    * chore: add more code docs
    
    ---------
    
    Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com>
    chatton and colin-axner authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    41c6656 View commit details
    Browse the repository at this point in the history
  2. Use new port router for onchanupgradetry (#7067)

    * chore: add fee implementation for OnChanOpenTry
    
    * chore: fix wiring in app.gos
    
    * chore: updated callbacks tests to handle new OnChanOpenTry
    
    * chore: lint, correct error string
    
    * chore: remove commented code
    
    * chore: addressing PR feedback
    chatton authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    9460400 View commit details
    Browse the repository at this point in the history
  3. Use new port router for OnChanOpenAck (#7084)

    * refactor: use new port router for OnChanOpenAck
    
    * fix: transfer test
    
    * fix: controller tests
    
    * fix: legacy ibc module handler on disabling
    colin-axner authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    6ec1efa View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Use new port router for OnChanUpgradeInit (#7082)

    * chore: add fee implementation for OnChanOpenTry
    
    * chore: fix wiring in app.gos
    
    * chore: updated callbacks tests to handle new OnChanOpenTry
    
    * chore: lint, correct error string
    
    * chore: remove commented code
    
    * chore: implementing OnChanUpgradeInit
    
    * chore: linter
    
    * chore: removed redundant test
    
    * chore: addressing PR feedback
    chatton authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    dc6e072 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ae43f7a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    63dd289 View commit details
    Browse the repository at this point in the history
  4. chore(api)!: move checks from Transfer to OnSendPacket (#7068)

    * deps: bump cosmos-sdk to v0.50.9 (#6828)
    
    * deps: bump cosmos-sdk to v0.50.8
    
    * chore: update changelog
    
    * deps: bump cosmossdk.io/client to v2.0.0-beta.3. bump x/upgrade to v0.1.4
    
    * chore: make tidy-all
    
    * test: bump to 3f6796fba413cca for testing purposes.
    
    * deps: bump cosmos sdk to 0.50.9
    
    * Update CHANGELOG.md
    
    * chore: update CHANGELOG for submodules.
    
    ---------
    
    Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
    
    * chore(api!): move checks from Transfer to OnSendPacket
    
    * Fix merge error
    
    * fix to test
    
    * Add Require() back
    
    * Update modules/apps/transfer/ibc_module.go
    
    Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
    
    * Linter
    
    * Removed wrong merge results
    
    * reintroduce test
    
    * Move check for isSendEnabledCoins to keeper
    
    * new tests
    
    * fixed test
    
    * linter
    
    * Removed checks and added comment
    
    * removed extra parentheses
    
    * Revert "Merge remote-tracking branch 'origin' into bznein/6949/msgTransferWrapperToSendPacket"
    
    This reverts commit be9f558, reversing
    changes made to 36e4b05.
    
    * Delete commented out code
    
    ---------
    
    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
    Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
    4 people authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    0c47e45 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    467819d View commit details
    Browse the repository at this point in the history
  6. Use new port router for OnChanUpgradeAck (#7094)

    * chore: implement OnChanUpgradeTry
    
    * wip: partial implementation for OnChanUpgradeAck
    
    * chore: updated tests to work with new OnChanUpgradeAck implementation
    chatton authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d779697 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    179025d View commit details
    Browse the repository at this point in the history
  8. Use new port router for OnChanUpgradeOpen (#7102)

    * chore: implement OnChanUpgradeTry
    
    * wip: partial implementation for OnChanUpgradeAck
    
    * chore: updated tests to work with new OnChanUpgradeAck implementation
    
    * chore: implemented OnChanUpgradeOpen
    
    * chore: addressing PR feedback
    chatton authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    62db721 View commit details
    Browse the repository at this point in the history
  9. refactor: replace ack interface with result type for OnRecvPacket (#7093

    )
    
    * refactor: update OnRecvPacket to use result type in favour of ack interface
    
    * refactor: update recv packet handling in interchain accounts, update event func arg to use concrete type
    
    * api! remove Acknowledgement interface from exported pkg
    
    * refactor: modifications to test code for api removal
    
    * lint: fix duplicate imports
    
    * refactor: use concrete acknowledgement in callbacks test
    
    * doc: update inline godocs for OnRecvPacket in ibccallbacks
    
    * fix: remove wrapping of result ack in callbacks recv packet
    
    * test: refactor writeAck tests to use expected error format
    
    * chore: add godocs and stringer impl for new recv result types
    
    * chore: add issue link for async acknowledgements in 29-fee
    
    * doc: update godocs for RecvPacketResult and status enums
    
    * chore: address pr comments, test updates and inline docs
    damiannolan authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    48b6a3f View commit details
    Browse the repository at this point in the history
  10. imp (api)!: convert coins to token only once in MsgTransfer (#7110)

    * test not working
    
    * refactored test and removed unneeded caese
    bznein authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d9c4e96 View commit details
    Browse the repository at this point in the history
  11. use new port router with OnAcknowledgementPacket (#7108)

    * refactor: use new port router for OnAcknowledgementPacket
    
    * fix: msg server update
    
    * fix: ics27 host tests
    
    * fix: ics27 controller tests
    
    * lint
    
    * chore: docs
    
    * add type assertions
    
    * add 29 type assertion
    colin-axner authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    0ea612a View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. chore: docs (#7111)

    colin-axner authored Aug 12, 2024
    Configuration menu
    Copy the full SHA
    a9d34ba View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Bznein/7023/on timeout packet (#7144)

    * initial commit
    
    * revert change
    
    * loop callbacks
    
    * fix loop
    
    * wip
    
    * chore: fixing remainder of timeout test failures
    
    * chore: check type assertion
    
    * PR feedbacK
    
    ---------
    
    Co-authored-by: chatton <cian@interchain.io>
    bznein and chatton authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    ec593cb View commit details
    Browse the repository at this point in the history
  2. Add convenience func to reverse callbacks and refactor other methods (#…

    …7142)
    
    * chore: updated handlers to use reverseCallbacks function
    
    * chore: add reconstructVersion to im
    
    * chore: remove duplicate import
    
    * chore: pr feedback
    chatton authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f5ab15b View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    6327b58 View commit details
    Browse the repository at this point in the history