-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new port router for OnChanUpgradeAck #7094
Use new port router for OnChanUpgradeAck #7094
Conversation
@@ -334,7 +334,39 @@ func (im *LegacyIBCModule) OnChanUpgradeTry(ctx sdk.Context, portID, channelID s | |||
} | |||
|
|||
// OnChanUpgradeAck implements the IBCModule interface | |||
func (LegacyIBCModule) OnChanUpgradeAck(ctx sdk.Context, portID, channelID, counterpartyVersion string) error { | |||
func (im *LegacyIBCModule) OnChanUpgradeAck(ctx sdk.Context, portID, channelID, counterpartyVersion string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as OnChanUpgradeTry except the negotiatedVersions array was removed.
@@ -1285,70 +1285,6 @@ func (suite *KeeperTestSuite) TestChannelUpgradeAck() { | |||
ibctesting.AssertEvents(&suite.Suite, expEvents, events) | |||
}, | |||
}, | |||
{ | |||
"application callback returns error and error receipt is written", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no more underlying app
…ter-for-onchanupgradeack
Quality Gate failed for 'ibc-go'Failed conditions |
Description
closes: #7028
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.