feat: adding chanUpgradeAck handler to 04-channel
#3828
Conversation
damiannolan
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei and
chatton
as code owners
| false, | ||
| }, | ||
| { | ||
| "channel end version mismatch on crossing hellos", |
There was a problem hiding this comment.
spoke with @AdityaSripal about this yesterday, testing this case as a full integration with the testing lib is tricky as its a timing sensitive state we end up, which would require a historical proof being submitted for the second chain to transition to TRY.
I chose to override the channel state directly here in order to cover this case.
There was a problem hiding this comment.
Maybe we can open an issue to make the test case more robust? It might be nice to have a test which simulates this scenario as it would potentially occur
| false, | ||
| }, | ||
| { | ||
| "channel end version mismatch on crossing hellos", |
There was a problem hiding this comment.
Maybe we can open an issue to make the test case more robust? It might be nice to have a test which simulates this scenario as it would potentially occur
damiannolan
changed the title
chanUpgradeAck handler to 04-channelchanUpgradeAck handler to 04-channel
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
| return errorsmod.Wrapf(types.ErrInvalidFlushStatus, "expected one of [%s, %s], got %s", types.FLUSHING, types.FLUSHCOMPLETE, counterpartyFlushStatus) | ||
| } | ||
|
|
||
| connection, err := k.GetConnection(ctx, channel.ConnectionHops[0]) |
There was a problem hiding this comment.
Should we do this instead?
| connection, err := k.GetConnection(ctx, channel.ConnectionHops[0]) | |
| connection, err := k.connectionKeeper.GetConnection(ctx, channel.ConnectionHops[0]) |
I believe this is the way we retrieve the connection from the channel keeper in the rest of the 04-channel codebase. If I'm not mistaken, the GetConnection function in channel keeper is only used in ICA, since it is not possible to access the connection keeper from there.
There was a problem hiding this comment.
seems like all of the channel upgradability code is currently using k.GetConnection(), maybe we could address all together and choose one for consistency in a follow up PR.
There was a problem hiding this comment.
opened #3840 as I'd like to get this merged
Description
Adding 04-channel handler for
ChanUpgradeAck, msg server implementation PR will follow this.closes: #3741
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.