Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0.39 x/auth Migration Types #6870

Merged
merged 5 commits into from
Jul 28, 2020
Merged

Fix 0.39 x/auth Migration Types #6870

merged 5 commits into from
Jul 28, 2020

Conversation

alexanderbez
Copy link
Contributor

Description

Ref: #6829

Forgot to add Coins to JSON output. Added migration tests.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alexanderbez alexanderbez added A:automerge Automatically merge PR once all prerequisites pass. C:x/auth labels Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #6870 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6870      +/-   ##
==========================================
+ Coverage   61.29%   61.31%   +0.01%     
==========================================
  Files         510      511       +1     
  Lines       31635    31648      +13     
==========================================
+ Hits        19392    19405      +13     
  Misses      10727    10727              
  Partials     1516     1516              

@alexanderbez alexanderbez marked this pull request as ready for review July 28, 2020 17:14
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mergify mergify bot merged commit 72f6bf0 into master Jul 28, 2020
@mergify mergify bot deleted the bez/fix-0_39_types branch July 28, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants