Launchpad Migration #6829

alexanderbez · 2020-07-23T13:38:20Z

Description

Move what was once 0.39 to 0.40 (since we decided to create launchpad)
Introduce a new 0.39 that migrates accounts (only JSON re-encode since types technically do not change)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

codecov · 2020-07-23T13:41:51Z

Codecov Report

Merging #6829 into master will increase coverage by 1.49%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6829      +/-   ##
==========================================
+ Coverage   59.80%   61.29%   +1.49%     
==========================================
  Files         288      510     +222     
  Lines       18496    31635   +13139     
==========================================
+ Hits        11061    19392    +8331     
- Misses       6510    10727    +4217     
- Partials      925     1516     +591

amaury1093

lgtm

fedekunze · 2020-07-28T10:17:23Z

x/bank/legacy/v0_40/types.go

@@ -1,4 +1,4 @@
-package v039
+package v040


supply is missing

yeah, noticed that too. In #6839 i'll comb through all genesis states and see if a migration is needed for each of them, if supply is not here then i'll do it there

This PR isn't for 0.40, it's for 0.39. There is a separate issue to wrap up 0.40 which @amaurymartiny already pointed to.

fedekunze

utACK

anilcse

ACK

@okwme

* v0.38.4-RC1 * add release date * client/keys/parse: honor config changes (cosmos#6340) `keys parse` uses the global configuration before before client applications have had a chance to apply their settings. This change adds a `GetSealedConfig()` helper that waits for the config to be sealed before returning it. Fixes: cosmos#5091 Origin: cosmos@4e328d7 Author: Adam Bozanich <adam.boz@gmail.com> Reviewed-by: Alessio Treglia <alessio@tendermint.com> * Merge PR cosmos#6505: Backport v0.38.5: IAVL Bump (RC) & Pruning Refactor * Fix cl * Fix cl * Merge PR cosmos#6551: Ethanfrey/fix trace flag * Merge PR cosmos#6552: Add sender info to bank transfer event * Merge PR cosmos#6581: v0.38.5-RC1 * Add release date * deps: bump IAVL to 0.14 * cl++ * Merge PR cosmos#6618: backport 0.39.0 (launchpad): cherry pick cosmos#5839 * launchpad: bump tendermint to v0.33.6 (cosmos#6673) * launchpad: bump tendermint to v0.33.6 * cha-cha-cha * fix types.ChainAnteDecorators() panic (cosmos#5742) (cosmos#6669) ChainAnteDecorators() panics when no arguments are supplied. This change its behaviour and the function now returns a nil AnteHandler in case no AnteDecorator instances are supplied. Closes: cosmos#5741 * launchpad: register MsgFundCommunityPool to distribution codec (cosmos#6675) Closes: cosmos#6210 * client: backport IBC additions (cosmos#6682) * launchpad: backport cliCtx.QueryABCI * add prove flag * Save account for multi sending (cosmos#6674) Include changes from PR cosmos#6283 Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com> * baseapp: fix sender events accumulation (cosmos#6683) closes: cosmos#6306 original PR: cosmos#6307 * run go mod tidy * add changelog line re: issue that was not included in v0.38.5 * Fix changelog * add release notes * update CODEOWNERS as per STABLE_RELEASES.md Launchpad's Stable Release Managers team's current composition as approved by @okwme (ICF): * @alessio * @clevinson * @ethanfrey * Add milestone's URL * Revert "update CODEOWNERS as per STABLE_RELEASES.md" This reverts commit f384592. * fix typo * add example patch * launchpad: backport account sequence stuck (cosmos#6721) Launchpad fix for cosmos#6287 * update release notes * make explicit that the regression is fixed in 0.39 * update release notes * Update CHANGELOG.md * update release notes @ethanfrey * remove pruning info from changelog They have been moved to NEWS.md * Update NEWS.md Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> * Mege PR cosmos#6749: auth: remove custom JSON marshaling * mv NEWS.md -> RELEASE_NOTES.md Self-explanatory naming convention. * Update changelog * add reference to gaia software upgrade * x/staking: add call to iterator Close() method (cosmos#6794) Original pull request: cosmos#6791 * [ci] fix linter (cosmos#6795) * Merge PR cosmos#6842: Remove custom acc JSON marshl * Backport cosmos#5671: Add a Flag for CORS (cosmos#6853) This adds the --unsafe-cors flag functionality. From: cosmos#5671 Co-authored-by: Marko <marbar3778@yahoo.com> * Merge PR cosmos#6855: Allow passing through Content-Type (needed for POST) * Merge PR cosmos#6861: Revert "Backport 0.39.1: Remove Custom JSON Marshaling for Accounts" * Merge PR cosmos#6869: Backport 0.39.1: Launchpad Migration cosmos#6829 * Update changelog and release notes * Update x/auth/legacy/v0_39/types.go * Update x/auth/legacy/v0_38/types.go * Merge PR cosmos#6938: Fix v0.39 migrate test * Merge PR cosmos#6937: Bump Tendermint to v0.33.7 * Update x/auth/legacy/v0_39/types.go Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> * update RELEASE_NOTES.md * update changelog * test case with real genesis data (cosmos#6995) * incorporate Ethan Frey's suggestion * make format * Update go mod * Remove some ci files * Modify data for test Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Ethan Frey <ethanfrey@users.noreply.github.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com> Co-authored-by: Marko <marbar3778@yahoo.com>

@okwme

* v0.38.4-RC1 * add release date * client/keys/parse: honor config changes (cosmos#6340) `keys parse` uses the global configuration before before client applications have had a chance to apply their settings. This change adds a `GetSealedConfig()` helper that waits for the config to be sealed before returning it. Fixes: cosmos#5091 Origin: cosmos@4e328d7 Author: Adam Bozanich <adam.boz@gmail.com> Reviewed-by: Alessio Treglia <alessio@tendermint.com> * Merge PR cosmos#6505: Backport v0.38.5: IAVL Bump (RC) & Pruning Refactor * Fix cl * Fix cl * Merge PR cosmos#6551: Ethanfrey/fix trace flag * Merge PR cosmos#6552: Add sender info to bank transfer event * Merge PR cosmos#6581: v0.38.5-RC1 * Add release date * deps: bump IAVL to 0.14 * cl++ * Merge PR cosmos#6618: backport 0.39.0 (launchpad): cherry pick cosmos#5839 * launchpad: bump tendermint to v0.33.6 (cosmos#6673) * launchpad: bump tendermint to v0.33.6 * cha-cha-cha * fix types.ChainAnteDecorators() panic (cosmos#5742) (cosmos#6669) ChainAnteDecorators() panics when no arguments are supplied. This change its behaviour and the function now returns a nil AnteHandler in case no AnteDecorator instances are supplied. Closes: cosmos#5741 * launchpad: register MsgFundCommunityPool to distribution codec (cosmos#6675) Closes: cosmos#6210 * client: backport IBC additions (cosmos#6682) * launchpad: backport cliCtx.QueryABCI * add prove flag * Save account for multi sending (cosmos#6674) Include changes from PR cosmos#6283 Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com> * baseapp: fix sender events accumulation (cosmos#6683) closes: cosmos#6306 original PR: cosmos#6307 * run go mod tidy * add changelog line re: issue that was not included in v0.38.5 * Fix changelog * add release notes * update CODEOWNERS as per STABLE_RELEASES.md Launchpad's Stable Release Managers team's current composition as approved by @okwme (ICF): * @alessio * @clevinson * @ethanfrey * Add milestone's URL * Revert "update CODEOWNERS as per STABLE_RELEASES.md" This reverts commit f384592. * fix typo * add example patch * launchpad: backport account sequence stuck (cosmos#6721) Launchpad fix for cosmos#6287 * update release notes * make explicit that the regression is fixed in 0.39 * update release notes * Update CHANGELOG.md * update release notes @ethanfrey * remove pruning info from changelog They have been moved to NEWS.md * Update NEWS.md Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> * Mege PR cosmos#6749: auth: remove custom JSON marshaling * mv NEWS.md -> RELEASE_NOTES.md Self-explanatory naming convention. * Update changelog * add reference to gaia software upgrade * x/staking: add call to iterator Close() method (cosmos#6794) Original pull request: cosmos#6791 * [ci] fix linter (cosmos#6795) * Merge PR cosmos#6842: Remove custom acc JSON marshl * Backport cosmos#5671: Add a Flag for CORS (cosmos#6853) This adds the --unsafe-cors flag functionality. From: cosmos#5671 Co-authored-by: Marko <marbar3778@yahoo.com> * Merge PR cosmos#6855: Allow passing through Content-Type (needed for POST) * Merge PR cosmos#6861: Revert "Backport 0.39.1: Remove Custom JSON Marshaling for Accounts" * Merge PR cosmos#6869: Backport 0.39.1: Launchpad Migration cosmos#6829 * Update changelog and release notes * Update x/auth/legacy/v0_39/types.go * Update x/auth/legacy/v0_38/types.go * Merge PR cosmos#6938: Fix v0.39 migrate test * Merge PR cosmos#6937: Bump Tendermint to v0.33.7 * Update x/auth/legacy/v0_39/types.go Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> * update RELEASE_NOTES.md * update changelog * test case with real genesis data (cosmos#6995) * incorporate Ethan Frey's suggestion * make format * Update go mod * Remove some ci files * Modify data for test * API server * Port telemetry * Initial metrics * Fix measure * Merge PR cosmos#6761: telemetry: use UTC() in wrappers * Remove file * Make format * Revert changes to client * Revert changes to client/lcd/root * Revert renames in client * Fix int64 panics * Revert "Revert renames in client" This reverts commit cc0a95d14c3212fa1c49f93789dd94e167427a57. * Revert "Revert changes to client/lcd/root" This reverts commit e3bb87bbacae13676c3a1f86f8d441d576b1f2ba. * Revert "Revert changes to client" This reverts commit 332cacba3242e503bcc4bffc3f6b25c1906efca4. Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Ethan Frey <ethanfrey@users.noreply.github.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Adam Bozanich <adam.boz@gmail.com>

fix migration

6021d40

add 039 pkg

85ba661

alexanderbez added C:genesis relating to chain genesis C:x/genutil genutil module issues labels Jul 23, 2020

alexanderbez and others added 2 commits July 23, 2020 12:03

lint

60557e2

Merge branch 'master' into bez/6828-fix-0_39-migration

b85d399

alexanderbez closed this Jul 24, 2020

alexanderbez deleted the bez/6828-fix-0_39-migration branch July 24, 2020 15:24

alexanderbez restored the bez/6828-fix-0_39-migration branch July 27, 2020 14:16

alexanderbez reopened this Jul 27, 2020

alexanderbez and others added 6 commits July 27, 2020 10:17

Merge branch 'master' into bez/6828-fix-0_39-migration

2de3222

Fix pkg name

8a2b81f

add v0.39 auth types

75a7c08

remove file

a92b063

updates

c80b029

updates

5220993

alexanderbez marked this pull request as ready for review July 27, 2020 15:37

alexanderbez requested review from aaronc, alessio, clevinson, fedekunze and jgimeno as code owners July 27, 2020 15:37

update godoc

d22305f

alexanderbez added the backport/0.39.x (Launchpad) label Jul 27, 2020

alexanderbez requested a review from tac0turtle July 27, 2020 15:38

Merge branch 'master' into bez/6828-fix-0_39-migration

01c5f26

aaronc requested review from amaury1093, blushi and anilcse July 27, 2020 15:52

aaronc requested review from atheeshp and sahith-narahari July 27, 2020 15:52

alexanderbez added 3 commits July 27, 2020 12:10

Merge branch 'master' into bez/6828-fix-0_39-migration

d833860

Merge branch 'master' into bez/6828-fix-0_39-migration

375acf2

Merge branch 'master' into bez/6828-fix-0_39-migration

407aa2f

amaury1093 approved these changes Jul 28, 2020

View reviewed changes

Merge branch 'master' into bez/6828-fix-0_39-migration

2d4811a

fedekunze reviewed Jul 28, 2020

View reviewed changes

fedekunze approved these changes Jul 28, 2020

View reviewed changes

Merge branch 'master' into bez/6828-fix-0_39-migration

6dbfe29

alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 28, 2020

mergify bot merged commit 3ff3e58 into master Jul 28, 2020

mergify bot deleted the bez/6828-fix-0_39-migration branch July 28, 2020 15:28

This was referenced Jul 28, 2020

Backport 0.39.1: Launchpad Migration #6829 #6869

Merged

Fix 0.39 x/auth Migration Types #6870

Merged

anilcse reviewed Jul 28, 2020

View reviewed changes

alexanderbez added a commit that referenced this pull request Jul 29, 2020

Merge PR #6869: Backport 0.39.1: Launchpad Migration #6829

e82246e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Launchpad Migration #6829

Launchpad Migration #6829

alexanderbez commented Jul 23, 2020 •

edited

Loading

codecov bot commented Jul 23, 2020 •

edited

Loading

amaury1093 left a comment

fedekunze Jul 28, 2020

amaury1093 Jul 28, 2020

alexanderbez Jul 28, 2020

fedekunze left a comment

anilcse left a comment

Launchpad Migration #6829

Launchpad Migration #6829

Conversation

alexanderbez commented Jul 23, 2020 • edited Loading

Description

codecov bot commented Jul 23, 2020 • edited Loading

Codecov Report

amaury1093 left a comment

Choose a reason for hiding this comment

fedekunze Jul 28, 2020

Choose a reason for hiding this comment

amaury1093 Jul 28, 2020

Choose a reason for hiding this comment

alexanderbez Jul 28, 2020

Choose a reason for hiding this comment

fedekunze left a comment

Choose a reason for hiding this comment

anilcse left a comment

Choose a reason for hiding this comment

alexanderbez commented Jul 23, 2020 •

edited

Loading

codecov bot commented Jul 23, 2020 •

edited

Loading