Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core)!: add error return parameter to RegisterServices #15045

Merged
merged 2 commits into from
Feb 16, 2023
Merged

refactor(core)!: add error return parameter to RegisterServices #15045

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2593183
refactor(core)!: add error return parameter to RegisterServices
aaronc Feb 7, 2023
3c64361
Merge branch 'main' into aaronc/core-api-service-error
tac0turtle Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/appmodule/module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ type HasServices interface {
// The service registrar will figure out which type of service you are
// implementing based on the presence (or absence) of protobuf options. You
// do not need to specify this in golang code.
RegisterServices(grpc.ServiceRegistrar)
RegisterServices(grpc.ServiceRegistrar) error
}

// HasBeginBlocker is the extension interface that modules should implement to run
Expand Down