Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core)!: add error return parameter to RegisterServices #15045

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Feb 16, 2023

Description

I was initially thinking maybe we could avoid having the error here because gRPC RegisterServices doesn't return an error itself. But I think it's maybe not the best assumption to assume that all error code will be error free, so proposing we add the error here.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc requested a review from a team as a code owner February 16, 2023 14:55
@github-prbot github-prbot requested review from a team, tac0turtle and julienrbrt and removed request for a team February 16, 2023 14:55
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 16, 2023
@julienrbrt julienrbrt merged commit 94b0bdc into main Feb 16, 2023
@julienrbrt julienrbrt deleted the aaronc/core-api-service-error branch February 16, 2023 17:03
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants