Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Fix makefile install scripts #1337

Merged
merged 3 commits into from
Jun 22, 2018
Merged

tools: Fix makefile install scripts #1337

merged 3 commits into from
Jun 22, 2018

Conversation

ValarDragon
Copy link
Contributor

Previously, the install scripts weren't installing golint and gometalinter.
This commit fixes this, and installs tendermint's linter, and the HEAD of
the gometalinter repository. Now make all should work.
Closes #1052 , Closes #1190

  • Updated all relevant documentation in docs - I dont know of any documentation on this
  • Updated all code comments where relevant
  • Wrote tests - n/a
  • Updated CHANGELOG.md
  • Updated Gaia/Examples - n/a
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ValarDragon
tools: Fix install scripts
6e45ba9 
Previously, the install scripts weren't installing golint and gometalinter.
This commit fixes this, and installs tendermints linter, and the HEAD of
the gometalinter repository. Now make all should work.
@ValarDragon ValarDragon requested a review from cwgoes June 22, 2018 07:11
@codecov
Copy link

codecov bot commented Jun 22, 2018 •
edited
Loading

Codecov Report

Merging #1337 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1337   +/-   ##
=======================================
  Coverage     65.5%   65.5%           
=======================================
  Files          114     114           
  Lines         6305    6305           
=======================================
  Hits          4130    4130           
  Misses        1949    1949           
  Partials       226     226

cwgoes
cwgoes suggested changes Jun 22, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ANSI colors are cute but annoying for automated scripts / remote shells - can we stick to plaintext?

@ValarDragon
Copy link
Contributor Author

ANSI coloring removed

cwgoes
cwgoes approved these changes Jun 22, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@cwgoes cwgoes merged commit 7f1169d into develop Jun 22, 2018
@cwgoes cwgoes deleted the dev/makefile_include_linter_installation branch June 22, 2018 18:01
adrianbrink pushed a commit that referenced this pull request Jul 2, 2018
@ValarDragon
Merge PR #1337: tools: Fix makefile install scripts
d3352e2 
Previously, the install scripts weren't installing golint and gometalinter.
This commit fixes this, and installs tendermints linter, and the HEAD of
the gometalinter repository. Now make all should work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make get_tools isn't installing gometalinter Errors in makefile
2 participants
@ValarDragon @cwgoes