Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in makefile #1052

Closed
kyriediculous opened this issue May 24, 2018 · 2 comments · Fixed by #1337
Closed

Errors in makefile #1052

kyriediculous opened this issue May 24, 2018 · 2 comments · Fixed by #1337
Assignees
Labels

Comments

@kyriediculous
Copy link

kyriediculous commented May 24, 2018

DEV/MASTER BRANCHES

go get -u -v github.com/cosmos/cosmos-sdk
git pull origin master
make all 

Returns

cd tools && make check_tools
The system cannot find the path specified.
make[1]: Entering directory '%USERPROFILE%/go/src/github.com/cosmos/cosmos-sdk/tools'
"No dep in path.  Install with 'make get_tools'."
make[1]: Leaving directory ''%USERPROFILE%/go/src/github.com/cosmos/cosmos-sdk/tools'
process_begin: CreateProcess(NULL, rm -rf vendor/, ...) failed.
make (e=2): The system cannot find the file specified.
Makefile:66: recipe for target 'get_vendor_deps' failed
make: *** [get_vendor_deps] Error 2**

STABLE DOCUMENTATION:

go get -u github.com/cosmos/cosmos-sdk/cmd/...
cd $GOPATH/src/github.com/tendermint/basecoin
git pull origin master
make all

Does not work because .../tendermint/basecoin does not exist.

@kyriediculous
Copy link
Author

kyriediculous commented May 24, 2018

Using ubuntu I got a different error message telling me to run make get_tools after which make all succesfully runs.

I get a different error at the end however
gnometalinter --disable-all --enable='golint' --vendor ./...
make gnometalinter; command not found
Makefile:99 recipe for target 'test_lint' failed'
make: *** [test_Lint] error 127


osboxes@osboxes:~/src/github.com/cosmos/cosmos-sdk$ make get_tools
cd tools && make get_tools
make[1]: Entering directory '/home/osboxes/src/github.com/cosmos/cosmos-sdk/tools'
Installing dep
go get -v github.com/golang/dep/cmd/dep
github.com/golang/dep (download)
github.com/golang/dep/vendor/github.com/Masterminds/semver
github.com/golang/dep/vendor/github.com/Masterminds/vcs
github.com/golang/dep/vendor/github.com/armon/go-radix
github.com/golang/dep/vendor/github.com/boltdb/bolt
github.com/golang/dep/vendor/github.com/golang/protobuf/proto
github.com/golang/dep/gps/internal/pb
github.com/golang/dep/gps/paths
github.com/golang/dep/vendor/github.com/pkg/errors
github.com/golang/dep/gps/pkgtree
github.com/golang/dep/internal/fs
github.com/golang/dep/vendor/github.com/jmank88/nuts
github.com/golang/dep/vendor/github.com/nightlyone/lockfile
github.com/golang/dep/vendor/github.com/sdboyer/constext
github.com/golang/dep/vendor/golang.org/x/net/context
github.com/golang/dep/vendor/golang.org/x/sync/errgroup
github.com/golang/dep/gps
github.com/golang/dep/vendor/github.com/pelletier/go-toml
github.com/golang/dep
github.com/golang/dep/internal/feedback
github.com/golang/dep/internal/importers/base
github.com/golang/dep/vendor/gopkg.in/yaml.v2
github.com/golang/dep/internal/importers/glide
github.com/golang/dep/internal/importers/glock
github.com/golang/dep/internal/importers/godep
github.com/golang/dep/internal/importers/govend
github.com/golang/dep/internal/importers/govendor
github.com/golang/dep/internal/importers/gvt
github.com/golang/dep/internal/importers/vndr
github.com/golang/dep/internal/importers
github.com/golang/dep/cmd/dep
make[1]: Leaving directory '/home/osboxes/src/github.com/cosmos/cosmos-sdk/tools'
osboxes@osboxes:~/src/github.com/cosmos/cosmos-sdk$ make all
cd tools && make check_tools
make[1]: Entering directory '/home/osboxes/src/github.com/cosmos/cosmos-sdk/tools'
Found dep in path.
make[1]: Leaving directory '/home/osboxes/src/github.com/cosmos/cosmos-sdk/tools'
--> Running dep ensure
Gopkg.lock was already in sync with imports and Gopkg.toml
(1/49) Wrote github.com/bgentry/speakeasy@v0.1.0
(2/49) Wrote gopkg.in/yaml.v2@v2.2.1
(3/49) Wrote github.com/gorilla/mux@v1.6.2
(4/49) Wrote github.com/hashicorp/hcl@master
(5/49) Wrote github.com/inconshreveable/mousetrap@v1.0
(6/49) Wrote github.com/howeyc/crc16@master
(7/49) Wrote github.com/golang/protobuf@v1.0.0
(8/49) Wrote github.com/gorilla/websocket@v1.2.0
(9/49) Wrote github.com/davecgh/go-spew@v1.1.0
(10/49) Wrote github.com/ebuchman/fail-test@master
(11/49) Wrote github.com/fsnotify/fsnotify@v1.4.7
(12/49) Wrote github.com/go-logfmt/logfmt@v0.3.0
(13/49) Wrote github.com/go-stack/stack@v1.7.0
(14/49) Wrote github.com/gorilla/context@v1.1.1
(15/49) Wrote github.com/golang/snappy@master
(16/49) Wrote github.com/go-kit/kit@v0.6.0
(17/49) Wrote github.com/jmhodges/levigo@master
(18/49) Wrote github.com/kr/logfmt@master
(19/49) Wrote github.com/magiconair/properties@v1.8.0
(20/49) Wrote github.com/mattn/go-isatty@v0.0.3
(21/49) Wrote github.com/mitchellh/mapstructure@master
(22/49) Wrote github.com/pkg/errors@v0.8.0
(23/49) Wrote github.com/pelletier/go-toml@v1.1.0
(24/49) Wrote github.com/pmezard/go-difflib@v1.0.0
(25/49) Wrote github.com/btcsuite/btcd@master
(26/49) Wrote github.com/rcrowley/go-metrics@master
(27/49) Wrote github.com/spf13/afero@v1.1.0
(28/49) Wrote github.com/spf13/cast@v1.2.0
(29/49) Wrote github.com/spf13/cobra@v0.0.3
(30/49) Wrote github.com/gogo/protobuf@v1.0.0
(31/49) Wrote github.com/spf13/jwalterweatherman@master
(32/49) Wrote github.com/spf13/pflag@v1.0.1
(33/49) Wrote github.com/spf13/viper@v1.0.2
(34/49) Wrote github.com/stretchr/testify@v1.2.1
(35/49) Wrote github.com/syndtr/goleveldb@master
(36/49) Wrote github.com/tendermint/ed25519@master
(37/49) Wrote github.com/tendermint/go-crypto@v0.6.2
(38/49) Wrote github.com/tendermint/abci@v0.10.3
(39/49) Wrote github.com/tendermint/iavl@v0.7.0
(40/49) Wrote golang.org/x/crypto@master
(41/49) Wrote github.com/tendermint/go-wire@v0.7.3
(42/49) Wrote golang.org/x/net@master
(43/49) Wrote github.com/tendermint/tmlibs@v0.8.3-rc0
(44/49) Wrote github.com/tendermint/go-amino@0.9.9
(45/49) Wrote golang.org/x/sys@master
(46/49) Wrote golang.org/x/text@v0.3.0
(47/49) Wrote google.golang.org/genproto@7fd901a49ba6a7f87732eb344f6e3c5b19d1b200
(48/49) Wrote google.golang.org/grpc@v1.7.5
(49/49) Wrote github.com/tendermint/tendermint@v0.19.5-rc1
go install -ldflags "-X github.com/cosmos/cosmos-sdk/version.GitCommit=187be1a" ./cmd/gaia/cmd/gaiad
go install -ldflags "-X github.com/cosmos/cosmos-sdk/version.GitCommit=187be1a" ./cmd/gaia/cmd/gaiacli
go install -ldflags "-X github.com/cosmos/cosmos-sdk/version.GitCommit=187be1a" ./examples/basecoin/cmd/basecoind
go install -ldflags "-X github.com/cosmos/cosmos-sdk/version.GitCommit=187be1a" ./examples/basecoin/cmd/basecli
go install -ldflags "-X github.com/cosmos/cosmos-sdk/version.GitCommit=187be1a" ./examples/democoin/cmd/democoind
go install -ldflags "-X github.com/cosmos/cosmos-sdk/version.GitCommit=187be1a" ./examples/democoin/cmd/democli
gometalinter --disable-all --enable='golint' --vendor ./...
make: gometalinter: Command not found
Makefile:99: recipe for target 'test_lint' failed
make: *** [test_lint] Error 127

@ValarDragon
Copy link
Contributor

You're right, thanks for making the issue! (Just replicated on a clean ubuntu install) The intended work flow is running make all after you've already gotten the tools. However make get_tools isn't downloading gometalinter. (I'll open another issue for this)

Everything is working correctly on your system, its just that linting isn't being checked. Instead run make get_tools, make get_vendor_deps, and make install. Alternatively, you can use the installation script we made https://github.com/cosmos/cosmos-sdk/blob/rigel/spec-staking/scripts/install_sdk_ubuntu.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants