Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Table-Store (aka ORM) package - Genesis #10481

Merged
merged 88 commits into from
Nov 16, 2021

Conversation

blushi
Copy link
Contributor

@blushi blushi commented Nov 2, 2021

Description

closes: #9237
ref: #9156

This PR is a follow-up of #10451, #10415 and #9751 and the last PR for adding the ORM package to x/group.
It adds import/export genesis features.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #10481 (10dd18b) into master (878e3e8) will increase coverage by 0.03%.
The diff coverage is 77.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10481      +/-   ##
==========================================
+ Coverage   65.11%   65.15%   +0.03%     
==========================================
  Files         604      608       +4     
  Lines       57862    58022     +160     
==========================================
+ Hits        37678    37803     +125     
- Misses      18090    18106      +16     
- Partials     2094     2113      +19     
Impacted Files Coverage Δ
x/auth/types/account.go 76.16% <ø> (+0.73%) ⬆️
x/staking/keeper/migrations.go 50.00% <0.00%> (ø)
x/staking/keeper/msg_server.go 0.68% <0.00%> (-0.01%) ⬇️
x/group/internal/orm/table.go 81.69% <42.42%> (-10.81%) ⬇️
crypto/keyring/keyring.go 62.01% <50.00%> (ø)
x/group/internal/orm/auto_uint64.go 66.66% <53.84%> (-5.21%) ⬇️
x/upgrade/plan/downloader.go 81.48% <81.48%> (ø)
x/staking/types/params.go 46.03% <84.21%> (+8.06%) ⬆️
x/upgrade/plan/info.go 94.00% <94.00%> (ø)
store/iavl/store.go 67.98% <100.00%> (-4.94%) ⬇️
... and 12 more

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, couple of nits.

x/group/internal/orm/orm_scenario_test.go Outdated Show resolved Hide resolved
x/group/internal/orm/orm_scenario_test.go Show resolved Hide resolved
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

Later on, adding benchmarks would be useful.

Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. second Atheesh comments.

x/group/internal/orm/genesis.go Outdated Show resolved Hide resolved
x/group/internal/orm/genesis_test.go Show resolved Hide resolved
@blushi blushi added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 16, 2021
@blushi blushi mentioned this pull request Nov 16, 2021
@mergify mergify bot merged commit 3184cfc into master Nov 16, 2021
@mergify mergify bot deleted the marie/9237-table-store-4 branch November 16, 2021 16:08
blewater pushed a commit to e-money/cosmos-sdk that referenced this pull request Dec 8, 2021
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

closes: cosmos#9237
ref: cosmos#9156

This PR is a follow-up of cosmos#10451, cosmos#10415 and cosmos#9751 and the last PR for adding the ORM package to `x/group`.
It adds import/export genesis features.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [x] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add v1 Table-Store (aka ORM) package
5 participants