Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use memdb in ORM tests #10556

Closed
blushi opened this issue Nov 16, 2021 · 3 comments
Closed

Use memdb in ORM tests #10556

blushi opened this issue Nov 16, 2021 · 3 comments

Comments

@blushi
Copy link
Contributor

blushi commented Nov 16, 2021

ref: #10481 (comment)

Use github.com/cosmos/cosmos-sdk/db/memdb in x/group/internal/orm tests instead of the current setup:

ctx := NewMockContext()
store := ctx.KVStore(sdk.NewKVStoreKey("test"))
@tac0turtle
Copy link
Member

I couldn't find this line of code in orm. Will this code land in a later pr?

@tac0turtle
Copy link
Member

closing this as the orm has changed quite a bit since this issue was opened

@blushi
Copy link
Contributor Author

blushi commented Feb 14, 2022

This was for the old version of the ORM that lives in x/group/internal/orm (currently still being used in x/group)
But not sure how important that is now since we'll eventually use the new ORM implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants