Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark mem ballast flag as deprecated #5816

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Mar 17, 2024

What this PR does:
Deprecate mem-ballast-size-bytes flag.

Which issue(s) this PR fixes:
Fixes #5283

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt?

cmd/cortex/main.go Outdated Show resolved Hide resolved
@alanprot
Copy link
Member

LGTM!

@yeya24
Copy link
Contributor Author

yeya24 commented Mar 18, 2024

Will merge on green

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
@yeya24 yeya24 merged commit a899c65 into cortexproject:master Mar 18, 2024
16 checks passed
@yeya24 yeya24 deleted the deprecate-ballastBytes branch March 18, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate & remove Heap Ballast
3 participants