New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate -distributor.shard-by-all-labels #6021

Open

friedrichg opened this issue Jun 17, 2024 · 1 comment · May be fixed by #6022

Assignees

Labels

difficulty/easy help wanted type/chore

Member

friedrichg commented Jun 17, 2024 •

edited

Loading

Describe the bug
This option is disabled by default and produces imbalanced ingesters, which is never desirable.

Expected behavior
The option should be enabled always and it should not be possible to disable it. We should remove the flag

Additional Context
This should be easy to do, here is a similar PR #5816
Also remove the docs at https://cortexmetrics.io/docs/configuration/arguments/#distributor

friedrichg added type/chore help wanted difficulty/easy labels

Contributor

tesla59 commented Jun 17, 2024

Hi @friedrichg I would like to work on this issue. Can u please assign it to me?

tesla59 linked a pull request

that will close this issue

Deprecate -distributor.shard-by-all-labels #6022

Open

3 tasks

friedrichg assigned tesla59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment