Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for feature selection #108

Merged
merged 12 commits into from
Sep 3, 2021
Merged

Add support for feature selection #108

merged 12 commits into from
Sep 3, 2021

Commits on Sep 2, 2021

  1. Added FEATURES option to corrosion_import_crate

    Brord van Wierst authored and tronical committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    79e498d View commit details
    Browse the repository at this point in the history
  2. Initial implementation of feature support via target property

    This patch builds on the parent commit, but changes the API
    to use a target property.
    
    Since this approach requires CMake >= 3.19, the rust2cpp test that received features
    was copied into the new features test and reverted from the old test, so that
    it can still be run with older cmake versions.
    tronical committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    a10009d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c77c89e View commit details
    Browse the repository at this point in the history
  4. Fix support for multiple features with CORROSION_FEATURES

    * Make sure to use a space separator for the cargo command line
    * Join the target property list to the expected comma delimiter for the generator
    tronical committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    7651db7 View commit details
    Browse the repository at this point in the history
  5. Simplify CMake syntax slightly for features command line

    And $<IF> without the else part can be rewritten as plain $<>
    tronical committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    8891682 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c671ed9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9d2eb07 View commit details
    Browse the repository at this point in the history
  8. Fix the multi-feature test

    Reference the second function that's guarded by the second feature, otherwise we don't
    know if both were passed.
    tronical committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    dd2cf71 View commit details
    Browse the repository at this point in the history
  9. Re-add support for FEATURES when importing crates

    This restores what 79e498d added initially,
    the most convenience API for the common case of importing just one crate.
    tronical committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    691ddba View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0350841 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    80e530a View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Fix all-features/no-default-featurtes target property override

    The target property is empty, if it does not exist. If it is not empty, then
    map it to the correct value (--foo) or the empty string.
    tronical committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    bb7b047 View commit details
    Browse the repository at this point in the history