Add support for feature selection #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch builds on the parent commit, but changes the API to use a target property. Since this approach requires CMake >= 3.19, the rust2cpp test that received features was copied into the new features test and reverted from the old test, so that it can still be run with older cmake versions.
* Make sure to use a space separator for the cargo command line * Join the target property list to the expected comma delimiter for the generator
And $<IF> without the else part can be rewritten as plain $<>
ogoffart
reviewed
Sep 2, 2021
README.md
Outdated
| @@ -152,6 +152,10 @@ The pairs can also be generator expressions, as they will be evaluated using $<G | |||
| For example this may be useful if the build scripts of crates look for environment variables. | |||
| This feature requires CMake >= 3.19.0. | |||
|
|
|||
| Cargo crates sometimes offer features, which traditionally can be specified with `cargo build` on the | |||
| command line as opt-in. You can select the features to use for a crate imported with Corrosion by | |||
| setting the `CORROSION_FEATURES` target list property on the targets created by `corrosion_import_crate`. | |||
There was a problem hiding this comment.
Maybe the README would benefit from an example
Hm, that's true. So |
Reference the second function that's guarded by the second feature, otherwise we don't know if both were passed.
yeah |
This restores what 79e498d added initially, the most convenience API for the common case of importing just one crate.
tronical
commented
Sep 3, 2021
The target property is empty, if it does not exist. If it is not empty, then map it to the correct value (--foo) or the empty string.
ogoffart
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge requests is based on the commit in #99 but changes the code to use a target property.