-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.0 | Update FAQ: Add "Warning without TAN" section #3322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review. The rest of the new German FAQ entries & the new English FAQ entries will follow tomorrow afternoon.
Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com>
@Ein-Tim thanks for your extensive feedback already. I've implemented most of the changes like you suggested. Conversations where I thought that you might want to give additional feedback for were left open, feel free to close them if you're happy with the result |
@larswmh Thanks for the great cooperation! I commented on some of the still open conversations that they can be resolved, as I can't resolve them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
German review finished!
General comment: I think it would be good to add a similar entry to the new section like this one "Werden Warnung aufgrund eines Schnelltests oder PCR-Tests unterschieden?", where the question whether the warned user can differentiate a SRS warning from a normal warning is answered.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I'll review the English text after my suggestions for German are implemented and @MikeMcC399's comments are addressed. |
Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com>
Suggestion: Können Warnungen verschiedener Arten unterschieden werden? Kontaktpersonen erhalten in ihrer Corona-Warn-App eine Warnung über eine Begegnung an einem Tag mit niedrigem (grüne Kachel) oder erhöhtem Risiko (rote Kachel). |
This comment was marked as resolved.
This comment was marked as resolved.
I would have suggested to put this into the new section "Warning without TAN", as this question just arises now that there are two different methods of warning. Since you're asking though, I have a feeling you might want to see it in another section. Which one do you think fits best? |
If applicable, I have applied your German suggestions to English too |
Thanks for your suggestion, it has been implemented in ff61d07
In my most recent commit, I've added this FAQ to the "Warning without TAN" section for now @Ein-Tim |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com>
Tagebuch -> Kontakt-Tagebuch Fix indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now! Mainly checked German texts.
Thank you very much for the great cooperation on this PR! I really appreciate & enjoy it! |
@Ein-Tim @MikeMcC399 Thanks a lot for the collaboration ! |
Just checking: I read the FAQ "Kann ich für einen registrierten positiven Testbefund als Krankschreibung nutzen?" This should probably be "Kann ich einen registrierten positiven Testbefund als Krankschreibung nutzen?" |
@BenzlerJ Thanks, we will correct this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenzlerJ's comment as in-line suggestion.
Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com>
* Update gulpfile.js * Update sitemap.json * Update sitemap_de.json * Create screenshots-archive-2-28_de.json * Create screenshots-archive-2-28.json * Update global.json * Create 2-28.html * Create 2-28.html * Update appToWebLinks.json * Update appToWebLinks.json * Update sitemap.json * Update sitemap_de.json * Update appToWebLinks.json add "#warn_without_tan", * Update gulpfile.js * Update gulpfile.mjs * Release 3.0: Update FAQ articles mentioning "Warn for others" (#3312) * Release 3.0: Update FAQ articles mentioning "Warn for others" * Apply suggested changes * Modify censored date for easier replacement later * Update Android version to 3.0.1 * Release 3.0 | Update FAQ: Add "Warning without TAN" section (#3322) * Update FAQ: Add Warning without TAN section * Add to FAQ landing page index * Apply suggestions from code review Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com> * Add rest of suggestions + English equivalents * Update #warn_without_tan_still_positive * Apply suggestions from code review Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com> * Apply suggestions from code review (+ English) * Apply suggestions / add #warn_without_tan_differentiate_warning * Apply suggestion Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com> * Translate suggestion + minor changes Tagebuch -> Kontakt-Tagebuch Fix indentation * Update #warn_without_tan_in_app_display * Correct title #warn_without_tan_sickness_certificate Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com> Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com> * Release 3.0 | Update #further_details: Change link of pandemic radar (#3317) * Release 3.0 | Update TAN FAQs (#3321) * add updates for the FAQ for the release 3.0 * add some changes to the update of release 3.0 * Apply suggestions from code review Co-authored-by: Lars <lars.wittmershaus@cuisine.digital> * update the Tan in English * Update src/data/faq.json Co-authored-by: Lars <lars.wittmershaus@cuisine.digital> * add some changes to faq.json * add some changes in der FAQ * Revert "add some changes in der FAQ" This reverts commit e98c409. * add changes in the FAQ text * punctuation Co-authored-by: Lars <lars.wittmershaus@cuisine.digital> Co-authored-by: Dipankar Sarkar <dipankar.sarkar@cuisine.digital> * [R 3.0] Screenshots (#3298) * 2-29 folder * Update screenshots_de.json * Update screenshots.json * 2.29 -> 3.0 * Update screenshots.json 2.9 -> 3.0 * 2022 -> 2023 * rename folder 2.29 -> 3.0 * Update global.json 2.29 -> 3.0 * Update sitemap_de.json 2022->2023 * Add 3.0 assets and compress * Remove link to deleted screenshot section * Fix double punctuation Co-authored-by: larswmh <lars.wittmershaus@cuisine.digital> * Replace dates * Release 3.0 | Add blog (#3329) * [R 3.0] Update privacy notice (#3173) * Update privacy.json * Update privacy_de.json * rename docs * add pdfs and set correct date Co-authored-by: Lars <lars.wittmershaus@cuisine.digital> Co-authored-by: Lars <wittmershaus.lars@gmail.com> Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com> Co-authored-by: MohamedZaghdoudi <117178964+MohamedZaghdoudi@users.noreply.github.com>
This PR adds the "Warning without TAN" section to the FAQ for the version 3.0 release.
For simplicity, I've put them all into one screenshot for each language. I hope this is sufficient for reviewing.
Anchors:
#warn_without_tan,
#warn_without_tan_how_to,
#warn_without_tan_error,
#warn_without_tan_digital_result,
#warn_without_tan_external_result,
#warn_without_tan_hotline,
#warn_without_tan_version,
#warn_without_tan_pcr_after_self_test,
#warn_without_tan_twice,
#warn_without_tan_still_positive,
#warn_without_tan_photo,
#warn_without_tan_how_often,
#warn_without_tan_family,
#warn_without_tan_event,
#warn_without_tan_quarantine,
#warn_without_tan_negative,
#warn_without_tan_contact_journal,
#warn_without_tan_self_test_certificate,
#warn_without_tan_sickness_certificate,
#warn_without_tan_in_app_display,
#warn_without_tan_risk_assessment,
#warn_without_tan_risk_assessment_different,
#warn_without_tan_differentiate_warning
Internal Tracking ID: EXPOSUREAPP-14205