Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R 3.0] Screenshots #3298

Merged
merged 13 commits into from
Jan 18, 2023
Merged

[R 3.0] Screenshots #3298

merged 13 commits into from
Jan 18, 2023

Conversation

dsarkar
Copy link
Member

@dsarkar dsarkar commented Dec 23, 2022

EN:
image
image
image

DE:
image
image
image


Internal Tracking ID: EXPOSUREAPP-14200

@dsarkar dsarkar requested a review from a team December 23, 2022 06:12
@dsarkar dsarkar changed the base branch from master to release/3.0 December 23, 2022 06:13
@dsarkar dsarkar marked this pull request as draft December 23, 2022 06:13
@dsarkar dsarkar self-assigned this Dec 23, 2022
@dsarkar dsarkar mentioned this pull request Dec 23, 2022
@brianebeling
Copy link
Member

brianebeling commented Dec 28, 2022

Todo:

  • Rename folder from 2.29 to 3.0
  • Check references to 2.29 folder and adjust to 3.0

@dsarkar dsarkar mentioned this pull request Dec 29, 2022
@MikeMcC399
Copy link
Contributor

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jan 10, 2023

Wouldn't it make sense to use an approach were screenshots of screens which were not changed by the update are just continued to be used from the versions before?

I hope you understand what I'm trying to say? 😅

@larswmh larswmh marked this pull request as ready for review January 18, 2023 07:38
@larswmh
Copy link
Member

larswmh commented Jan 18, 2023

@Ein-Tim @MikeMcC399
Thanks for sharing your concerns. I can assure you that we are actively working on the problem. See for example #3327, where we tested symlinking duplicate files. We're also taking Git LFS into consideration, but cannot decide that without further internal approvals. For the upcoming release we will stick with the usual procedures.

@dsarkar
Copy link
Member Author

dsarkar commented Jan 18, 2023

LGTM, can be merged

@larswmh larswmh merged commit 5497f31 into release/3.0 Jan 18, 2023
@larswmh larswmh deleted the feature/screenshots-3-0 branch January 18, 2023 13:03
larswmh added a commit that referenced this pull request Jan 18, 2023
* Update gulpfile.js

* Update sitemap.json

* Update sitemap_de.json

* Create screenshots-archive-2-28_de.json

* Create screenshots-archive-2-28.json

* Update global.json

* Create 2-28.html

* Create 2-28.html

* Update appToWebLinks.json

* Update appToWebLinks.json

* Update sitemap.json

* Update sitemap_de.json

* Update appToWebLinks.json

add "#warn_without_tan",

* Update gulpfile.js

* Update gulpfile.mjs

* Release 3.0: Update FAQ articles mentioning "Warn for others" (#3312)

* Release 3.0: Update FAQ articles mentioning "Warn for others"

* Apply suggested changes

* Modify censored date for easier replacement later

* Update Android version to 3.0.1

* Release 3.0 | Update FAQ: Add "Warning without TAN" section (#3322)

* Update FAQ: Add Warning without TAN section

* Add to FAQ landing page index

* Apply suggestions from code review

Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com>

* Add rest of suggestions + English equivalents

* Update #warn_without_tan_still_positive

* Apply suggestions from code review

Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com>

* Apply suggestions from code review (+ English)

* Apply suggestions / add #warn_without_tan_differentiate_warning

* Apply suggestion

Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com>

* Translate suggestion + minor changes

Tagebuch -> Kontakt-Tagebuch
Fix indentation

* Update #warn_without_tan_in_app_display

* Correct title #warn_without_tan_sickness_certificate

Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com>

Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com>

* Release 3.0 | Update #further_details: Change link of pandemic radar (#3317)

* Release 3.0 | Update TAN FAQs (#3321)

* add updates for the FAQ for the release 3.0

* add some changes to the update of release 3.0

* Apply suggestions from code review

Co-authored-by: Lars <lars.wittmershaus@cuisine.digital>

* update the Tan in English

* Update src/data/faq.json

Co-authored-by: Lars <lars.wittmershaus@cuisine.digital>

* add some changes to faq.json

* add some changes in der FAQ

* Revert "add some changes in der FAQ"

This reverts commit e98c409.

* add changes in the FAQ text

* punctuation

Co-authored-by: Lars <lars.wittmershaus@cuisine.digital>
Co-authored-by: Dipankar Sarkar <dipankar.sarkar@cuisine.digital>

* [R 3.0] Screenshots (#3298)

* 2-29 folder

* Update screenshots_de.json

* Update screenshots.json

* 2.29 -> 3.0

* Update screenshots.json

2.9 -> 3.0

* 2022 -> 2023

* rename folder 2.29 -> 3.0

* Update global.json

2.29 -> 3.0

* Update sitemap_de.json

2022->2023

* Add 3.0 assets and compress

* Remove link to deleted screenshot section

* Fix double punctuation

Co-authored-by: larswmh <lars.wittmershaus@cuisine.digital>

* Replace dates

* Release 3.0 | Add blog (#3329)

* [R 3.0] Update privacy notice (#3173)

* Update privacy.json

* Update privacy_de.json

* rename docs

* add pdfs and set correct date

Co-authored-by: Lars <lars.wittmershaus@cuisine.digital>
Co-authored-by: Lars <wittmershaus.lars@gmail.com>
Co-authored-by: Tim <67682506+Ein-Tim@users.noreply.github.com>
Co-authored-by: MohamedZaghdoudi <117178964+MohamedZaghdoudi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants