Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FAQ entries val_service_no_valid_dcc & val_service_result, add redirect to val_service_basics & add update to val_service_basics #2734

Merged
merged 4 commits into from
Apr 12, 2022

Conversation

Ein-Tim
Copy link
Contributor

@Ein-Tim Ein-Tim commented Apr 11, 2022

Description

This PR removes the FAQ entries val_service_no_valid_dcc & val_service_result, adds a redirect from these entries to val_service_basics.
It also removes multiple paragraphs from val_service_basics and adds an update to this FAQ entry.

What was changed

Screenshots

English German
English  German

Fixes #2624


Internal Tracking ID: EXPOSUREAPP-12730

This commit removes the FAQ entries "val_service_no_valid_dcc" & "val_service_result", adds a redirect from these entries to "val_service_basics" and removes multiple paragraphs from "val_service_basics" as well as adds an update to this FAQ entry.
@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 11, 2022

Hi @dsarkar

I hope this PR matches your imagination on how you wanted this to look like! Could you please provide an updated text for the update? I think this would be great! Thank you!

src/data/faq.json Outdated Show resolved Hide resolved
src/data/faq_de.json Outdated Show resolved Hide resolved
@dsarkar dsarkar marked this pull request as ready for review April 12, 2022 12:06
@dsarkar dsarkar requested a review from a team April 12, 2022 12:06
@dsarkar
Copy link
Member

dsarkar commented Apr 12, 2022

@Ein-Tim Thanks for the PR!

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 12, 2022

@dsarkar Is the new update text good to go?

Copy link
Contributor Author

@Ein-Tim Ein-Tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double white space, should be removed.

src/data/faq.json Outdated Show resolved Hide resolved
@dsarkar
Copy link
Member

dsarkar commented Apr 12, 2022

@Ein-Tim The question should be removed still: "When does a DCC validation service bring ...", same applies to DE version.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 12, 2022

@dsarkar I will take care of this!

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 12, 2022

@dsarkar

Just to make sure: You want the question to be removed and not to add the paragraph back, as seen in the screenshots of the OP, correct?

@dsarkar
Copy link
Member

dsarkar commented Apr 12, 2022

@Ein-Tim Correct, remove the Q&A about advantages. Thank you!

This commit adds a new update and does changes as they were requested.

Co-Authored-By: Tim <67682506+Ein-Tim@users.noreply.github.com>
@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 12, 2022

Done with 31da308 @dsarkar!

@dsarkar
Copy link
Member

dsarkar commented Apr 12, 2022

@Ein-Tim Many thanks!

@dsarkar
Copy link
Member

dsarkar commented Apr 12, 2022

@Ein-Tim Sorry, one last thing: "The Federal Ministry of Health (Bundesministerium für Gesundheit, BMG) has decided to enable several validation services after appropriate verification." should be removed. Do you do it, or shall I remove it? (Similar in DE)

src/data/faq.json Outdated Show resolved Hide resolved
src/data/faq_de.json Outdated Show resolved Hide resolved
@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 12, 2022

Will remove.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 12, 2022

Removed outdated sentence with 344114b. Sorry for not caching that earlier!

@dsarkar
Copy link
Member

dsarkar commented Apr 12, 2022

@Ein-Tim Thanks.... DE "Dem dient ein Corona Validation Service." got lost in translation.... ;-)

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 12, 2022

@dsarkar Fixed, force pushed. Sorry again.

@dsarkar
Copy link
Member

dsarkar commented Apr 12, 2022

@Ein-Tim No problem at all, thanks for all the effort, also thanks to @MikeMcC399 for reviewing!

@dsarkar dsarkar merged commit 76a8c1a into corona-warn-app:master Apr 12, 2022
@Ein-Tim Ein-Tim deleted the update/DCC-ticketing branch April 12, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAQ entry val_service_basics should inform about the current status of the certificate verification feature
3 participants