-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FAQ entries val_service_no_valid_dcc
& val_service_result
, add redirect to val_service_basics
& add update to val_service_basics
#2734
Conversation
This commit removes the FAQ entries "val_service_no_valid_dcc" & "val_service_result", adds a redirect from these entries to "val_service_basics" and removes multiple paragraphs from "val_service_basics" as well as adds an update to this FAQ entry.
Hi @dsarkar I hope this PR matches your imagination on how you wanted this to look like! Could you please provide an updated text for the update? I think this would be great! Thank you! |
@Ein-Tim Thanks for the PR! |
@dsarkar Is the new update text good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double white space, should be removed.
@Ein-Tim The question should be removed still: "When does a DCC validation service bring ...", same applies to DE version. |
@dsarkar I will take care of this! |
Just to make sure: You want the question to be removed and not to add the paragraph back, as seen in the screenshots of the OP, correct? |
@Ein-Tim Correct, remove the Q&A about advantages. Thank you! |
This commit adds a new update and does changes as they were requested. Co-Authored-By: Tim <67682506+Ein-Tim@users.noreply.github.com>
4475c15
to
31da308
Compare
@Ein-Tim Many thanks! |
@Ein-Tim Sorry, one last thing: "The Federal Ministry of Health (Bundesministerium für Gesundheit, BMG) has decided to enable several validation services after appropriate verification." should be removed. Do you do it, or shall I remove it? (Similar in DE) |
Will remove. |
Removed outdated sentence with |
@Ein-Tim Thanks.... DE "Dem dient ein Corona Validation Service." got lost in translation.... ;-) |
344114b
to
d56b485
Compare
@dsarkar Fixed, force pushed. Sorry again. |
@Ein-Tim No problem at all, thanks for all the effort, also thanks to @MikeMcC399 for reviewing! |
Description
This PR removes the FAQ entries
val_service_no_valid_dcc
&val_service_result
, adds a redirect from these entries toval_service_basics
.It also removes multiple paragraphs from
val_service_basics
and adds an update to this FAQ entry.What was changed
Screenshots
Fixes #2624
Internal Tracking ID: EXPOSUREAPP-12730